controllers: Add OcsClient and StorageClassClaim controllers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose A. Rivera <[email protected]>
Signed-off-by: Jose A. Rivera <[email protected]>
Signed-off-by: Jose A. Rivera <[email protected]>
jarrpa
force-pushed
the
initial-controllers
branch
from
60c0722 to
a72dcd7
Compare
Madhu-1
requested changes
Sep 22, 2022
| @@ -0,0 +1,81 @@ | |||
| /* | |||
| Copyright 2020 Red Hat, Inc. | |||
| type StorageClassClaimSpec struct { | ||
| //+kubebuilder:validation:Enum=blockpool;sharedfilesystem | ||
| Type string `json:"type"` | ||
| EncryptionMethod string `json:"encryptionMethod,omitempty"` |
There was a problem hiding this comment.
Need to add storageProfile to the spec
| For(&v1alpha1.OcsClient{}, builder.WithPredicates( | ||
| predicate.GenerationChangedPredicate{}, | ||
| )). | ||
| Watches(&source.Kind{Type: &v1alpha1.StorageClassClaim{}}, annotationMapFunc). |
There was a problem hiding this comment.
Question:- Why we are watching for storageclassclaim in ocsclient controller?
| // Apply status changes to the OcsClient | ||
| statusErr := r.Client.Status().Update(ctx, instance) | ||
| if statusErr != nil { | ||
| r.Log.Info("Failed to update OcsClient status.") |
| instance.Status.Phase = v1alpha1.OcsClientOffboarding | ||
|
|
||
| if res, err := r.offboardConsumer(instance, externalClusterClient); err != nil { | ||
| r.Log.Info("Offboarding in progress.", "Status", err) |
| allowVolumeExpansion := true | ||
| storageClass := &storagev1.StorageClass{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: r.storageClassClaim.Name, |
There was a problem hiding this comment.
a namespace is not required for storageclass as it is cluster scoped resources.
Comment on lines
+432
to
+434
| if reflect.DeepEqual(existing.Parameters, storageClass.Parameters) { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
We should have moved this inside existing.UID check as it make sense to have comparison only when storageclass exists
| if existing.UID != "" { | ||
|
|
||
| // Since we have to update the existing StorageClass, so we will delete the existing StorageClass and create a new one. | ||
| r.log.Info("StorageClass needs to be updated, deleting it.", "StorageClass", klog.KRef(storageClass.Namespace, existing.Name)) |
There was a problem hiding this comment.
no namespace required for storageclass
| // Delete the StorageClass. | ||
| err := r.delete(existing) | ||
| if err != nil { | ||
| r.log.Error(err, "Failed to delete StorageClass.", "StorageClass", klog.KRef(storageClass.Namespace, existing.Name)) |
There was a problem hiding this comment.
no namespace required for storageclass
| return err | ||
| } | ||
| } | ||
| r.log.Info("Creating StorageClass.", "StorageClass", klog.KRef(storageClass.Namespace, existing.Name)) |
There was a problem hiding this comment.
no namespace required for storageclass
Closed
|
Closing in favor of #6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jose A. Rivera [email protected]