Merge pull request #289 from rewantsoni/fix-reconcile-loop

controllers: use semantic deepequal
red-hat-storage · Dec 4, 2024 · 3bfb808 · 3bfb808
2 parents c99a838 + 857baae
commit 3bfb808
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/utils/k8sutils.go b/pkg/utils/k8sutils.go
@@ -23,9 +23,9 @@ import (
 	"fmt"
 	"maps"
 	"os"
-	"reflect"
 	"time"
 
+	"k8s.io/apimachinery/pkg/api/equality"
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"sigs.k8s.io/controller-runtime/pkg/client"
@@ -153,7 +153,7 @@ func CreateOrReplace(ctx context.Context, c client.Client, obj client.Object, f
 		return err
 	}
 
-	if reflect.DeepEqual(existing, obj) {
+	if equality.Semantic.DeepEqual(existing, obj) {
 		return nil
 	}