Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding volumeMode param to snapshot_restore_factory #9967

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

keemano
Copy link
Contributor

@keemano keemano commented Jun 20, 2024

This PR fixes #9966

Currently, we create source pvc with block volumemode but during restore snapshot , by default it take filesystem, which causes test case to fail.
This fix add additional param called volume_mode to snapshot_restore_factory

@keemano keemano requested a review from a team as a code owner June 20, 2024 05:48
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: kmanohar-t
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/pv/pv_services/test_rbd_image_metadata.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: kmanohar-t
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/pv/pv_services/test_rbd_image_metadata.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: kmanohar-t
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/pv/pv_services/test_rbd_image_metadata.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jilju, keemano, nehaberry, paraggit

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: kmanohar-t
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/pv/pv_services/test_rbd_image_metadata.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@keesturam keesturam merged commit 483766b into red-hat-storage:master Jun 20, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_rbd_image_metadata fails due to mismatch in volume mode
6 participants