skip oadp install on managed clusters fix:bz2280657 #9949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parikshith <[email protected]>
parikshithb
added
Needs Testing
sidhant-agrawal
approved these changes
Jun 14, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: parikshithb, sidhant-agrawal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hnallurv
reviewed
Jun 21, 2024
| @@ -662,7 +662,6 @@ def deploy_cluster(self, log_cli_level="DEBUG"): | |||
| self.do_deploy_submariner() | |||
| self.do_gitops_deploy() | |||
| self.do_deploy_ocs() | |||
| self.do_deploy_oadp() | |||
There was a problem hiding this comment.
Please check this comment https://bugzilla.redhat.com/show_bug.cgi?id=2280657#c13 and do the needful based on the answer from Talur
There was a problem hiding this comment.
Based on the latest comment https://bugzilla.redhat.com/show_bug.cgi?id=2280657#c14, fix has been reverted and need to install OADP manually. Closing this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now expected that OADP is installed by ramen automatically, bz: https://bugzilla.redhat.com/show_bug.cgi?id=2280657
Need deployment testing to verify this pr/bz.