Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test to check for values in securityKeyRef in pod #9948

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

shivamdurgbuns
Copy link
Member

@shivamdurgbuns shivamdurgbuns commented Jun 14, 2024

@shivamdurgbuns shivamdurgbuns requested a review from a team as a code owner June 14, 2024 08:17
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Jun 14, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: sdurgbun-cluster416
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/internal/test_secrets_on_pods.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines and removed size/M PR that changes 30-99 lines labels Jun 14, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: sdurgbun-cluster416
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/internal/test_secrets_on_pods.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@openshift-ci openshift-ci bot added the lgtm label Jul 4, 2024
@shivamdurgbuns shivamdurgbuns added the Verified Mark when PR was verified and log provided label Jul 4, 2024
@shivamdurgbuns shivamdurgbuns requested review from a team and removed request for a team July 4, 2024 08:24
Copy link
Contributor

@pintojoy pintojoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pintojoy, ramkiperiy, shivamdurgbuns

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ramkiperiy ramkiperiy merged commit c0d331c into red-hat-storage:master Jul 17, 2024
5 of 6 checks passed
amr1ta pushed a commit to amr1ta/ocs-ci that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/L PR that changes 100-499 lines Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants