Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshot fixture to handle provider mode client #9944

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

jilju
Copy link
Contributor

@jilju jilju commented Jun 13, 2024

Volumesnapshot class names are not constant anymore in client clusters. Updated the snapshot restore fixture to handle this.
Fixes #9943

@jilju jilju requested a review from a team as a code owner June 13, 2024 14:45
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Jun 13, 2024
@jilju jilju added provider-client Provider-client solution Squad/Green labels Jun 13, 2024
@jilju
Copy link
Contributor Author

jilju commented Jun 14, 2024

Verified on client cluster in provider mode setup. The name of storageclass is "storage-client-ceph-rbd". Logs attached.
verify_pr_9944.txt

@jilju jilju added the Verified Mark when PR was verified and log provided label Jun 14, 2024
Copy link
Contributor

@amr1ta amr1ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Copy link

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amr1ta, jilju, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vavuthu vavuthu merged commit 8977d25 into red-hat-storage:master Jun 14, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm provider-client Provider-client solution size/S PR that changes 10-29 lines Squad/Green Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot tests failing on client in provider mode configuration
3 participants