Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set encryption on provider client mode clusters #9937

Closed

Conversation

fbalak
Copy link
Contributor

@fbalak fbalak commented Jun 12, 2024

No description provided.

@fbalak fbalak added the provider-client Provider-client solution label Jun 12, 2024
@fbalak fbalak self-assigned this Jun 12, 2024
@fbalak fbalak requested a review from a team as a code owner June 12, 2024 12:37
@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines size/M PR that changes 30-99 lines and removed size/S PR that changes 10-29 lines labels Jun 12, 2024
@fbalak fbalak requested review from a team as code owners June 14, 2024 17:07
@pull-request-size pull-request-size bot added size/XL and removed size/M PR that changes 30-99 lines labels Jun 14, 2024
@fbalak fbalak force-pushed the provider-client-encryption branch from ad689e6 to 94dd8a5 Compare June 14, 2024 17:09
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines and removed size/XL labels Jun 14, 2024
@fbalak fbalak force-pushed the provider-client-encryption branch from ac4f89b to 2ae31ab Compare June 17, 2024 11:44
@fbalak
Copy link
Contributor Author

fbalak commented Jun 17, 2024

Verified: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/38749/
ODF with KMS was and encryption set was correctly installed.

@fbalak fbalak added the Verified Mark when PR was verified and log provided label Jun 17, 2024
@fbalak fbalak force-pushed the provider-client-encryption branch from 2ae31ab to f5d393c Compare June 17, 2024 11:47
DanielOsypenko
DanielOsypenko previously approved these changes Jun 17, 2024
jilju
jilju previously approved these changes Jun 17, 2024
Comment on lines 198 to 209
if config.ENV_DATA.get("encryption_at_rest"):
log.info("Enabling encryption at REST!")
storage_cluster_data["spec"]["encryption"] = {
"enable": True,
}
storage_cluster_data["spec"]["encryption"] = {
"clusterWide": True,
}
if config.DEPLOYMENT.get("kms_deployment"):
storage_cluster_data["spec"]["encryption"]["kms"] = {
"enable": True,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fbalak fbalak dismissed stale reviews from jilju and DanielOsypenko via 6911597 June 19, 2024 09:33
@openshift-ci openshift-ci bot removed the lgtm label Jun 19, 2024
Copy link

openshift-ci bot commented Jun 19, 2024

New changes are detected. LGTM label has been removed.

@fbalak fbalak closed this Jun 24, 2024
@fbalak fbalak force-pushed the provider-client-encryption branch from 12bdad1 to aff4598 Compare June 24, 2024 13:03
@pull-request-size pull-request-size bot removed the size/M PR that changes 30-99 lines label Jun 24, 2024
Copy link

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fbalak

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider-client Provider-client solution size/XS Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants