-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set encryption on provider client mode clusters #9937
Conversation
ad689e6
to
94dd8a5
Compare
ac4f89b
to
2ae31ab
Compare
Verified: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/38749/ |
2ae31ab
to
f5d393c
Compare
if config.ENV_DATA.get("encryption_at_rest"): | ||
log.info("Enabling encryption at REST!") | ||
storage_cluster_data["spec"]["encryption"] = { | ||
"enable": True, | ||
} | ||
storage_cluster_data["spec"]["encryption"] = { | ||
"clusterWide": True, | ||
} | ||
if config.DEPLOYMENT.get("kms_deployment"): | ||
storage_cluster_data["spec"]["encryption"]["kms"] = { | ||
"enable": True, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code block repeats itself in https://github.com/red-hat-storage/ocs-ci/pull/9937/files#diff-6db332fb7e8994706a556a7323940b65f5904163d25739a7f960603e3df1afb0R220. Can we move it to a common function?
New changes are detected. LGTM label has been removed. |
12bdad1
to
aff4598
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fbalak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.