Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyrotation verification added in the add_capacity test #9919

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

paraggit
Copy link
Contributor

@paraggit paraggit commented Jun 7, 2024

Added OSD keyrotation verification checks in the test_add_capacity_entry_exit_criteria.py test.

@paraggit paraggit requested review from a team as code owners June 7, 2024 09:51
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Jun 7, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_add_capacity_entry_exit_criteria.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

@paraggit paraggit added the Verified Mark when PR was verified and log provided label Jun 12, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_add_capacity_entry_exit_criteria.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/z_cluster/cluster_expansion/test_add_capacity_entry_exit_criteria.py
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@paraggit paraggit requested a review from AviadP June 13, 2024 08:54
Copy link
Contributor

@AviadP AviadP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AviadP, ebenahar, paraggit

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebenahar ebenahar merged commit 88ff6f8 into red-hat-storage:master Jun 13, 2024
6 of 7 checks passed
fbalak pushed a commit to fbalak/ocs-ci that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/M PR that changes 30-99 lines Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants