Fix OADP and Gitops Operator install #9905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am-agrawa
previously approved these changes
Jun 6, 2024
prsurve
force-pushed
the
fix_oadp_and_gitops
branch
from
a7ae7c4 to
a1ec124
Compare
sidhant-agrawal
previously approved these changes
Jun 7, 2024
prsurve
force-pushed
the
fix_oadp_and_gitops
branch
from
6416027 to
e3fb50b
Compare
am-agrawa
previously approved these changes
Jul 17, 2024
shylesh
reviewed
Jul 19, 2024
ocs_ci/deployment/deployment.py
Outdated
|
|
||
| self.wait_for_subscription( | ||
| constants.GITOPS_OPERATOR_NAME, namespace=constants.OPENSHIFT_OPERATORS | ||
| ) | ||
| logger.info("Sleeping for 90 seconds after subscribing to GitOps Operator") | ||
| time.sleep(90) | ||
| logger.info("Sleeping for 120 seconds after subscribing to GitOps Operator") |
There was a problem hiding this comment.
@prsurve do we really need sleep here, can't we wait on some resource?
Signed-off-by: prsurve <[email protected]>
Signed-off-by: prsurve <[email protected]>
Signed-off-by: prsurve <[email protected]>
prsurve
force-pushed
the
fix_oadp_and_gitops
branch
from
e3fb50b to
00d1753
Compare
am-agrawa
approved these changes
Jul 19, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: am-agrawa, prsurve, shylesh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merging this as MDR deployment is blocked |
amr1ta
pushed a commit
to amr1ta/ocs-ci
that referenced
this pull request
Jul 25, 2024
* Fix OADP and Gitops Operator install * Fix OADP and Gitops Operator install * Remove sleep --------- Signed-off-by: prsurve <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.