Fixes test_ocs_operator_is_not_present for utilizing custom namespace #9877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: suchita-g <[email protected]> In Test case test_ocs_operator_is_not_present the use of namespace "openshift-storage" is hardcoded, hence this test is failing on platform where custom name is used for ODF deployment, like ROSA/AWS HCP Fix for: red-hat-storage#9876 Signed-off-by: suchita-g <[email protected]>
ocs-ci
reviewed
May 30, 2024
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: vkathole-416
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/cross_functional/ui/test_validation_ui.py::TestUserInterfaceValidation::test_ocs_operator_is_not_present
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master
suchita-g
force-pushed
the
Fix_9876_test_ocs_operator_is_not_present
branch
from
811810a to
3d3df15
Compare
am-agrawa
approved these changes
May 31, 2024
ebondare
approved these changes
May 31, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: am-agrawa, ebondare, suchita-g The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Test case test_ocs_operator_is_not_present the use of namespace "openshift-storage" is hardcoded, hence this test is failing on platform where custom name is used for ODF deployment, like ROSA/AWS HCP Fix for: #9876
Signed-off-by: suchita-g [email protected]