-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify the owner of CSI deployments and daemonsets #9865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jilju Joy <[email protected]>
Signed-off-by: Jilju Joy <[email protected]>
Signed-off-by: Jilju Joy <[email protected]>
Signed-off-by: Jilju Joy <[email protected]>
ebondare
reviewed
May 31, 2024
Signed-off-by: Jilju Joy <[email protected]>
vavuthu
approved these changes
Jun 17, 2024
ebondare
approved these changes
Jun 17, 2024
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ebondare, jilju, vavuthu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify the owner of CSI deployments and daemonsets. This is currently implemented for non-provider mode only. The verification function is not implemented for provider mode. It will be added separately following the PR #9144.
The OwnerReference will be different for provider mode and non-provider mode.
Verification is done to ensure that changes in owner for provider mode is not affected in internal mode.