Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure CoreDNS for enabling access to buckets with DNS subdomain style (Virtual Host style) #9839

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dahorak
Copy link
Contributor

@dahorak dahorak commented May 22, 2024

Adding new fixture virtual_host_style_acess_for_rgw_session which configures the CoreDNS used for accessing buckets with DNS subdomain style.

Related to https://url.corp.redhat.com/192db17

@dahorak dahorak added the team/ecosystem Ecosystem team related issues/PRs label May 22, 2024
@dahorak dahorak self-assigned this May 22, 2024
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label May 22, 2024
@dahorak dahorak force-pushed the ocsqe-2099-access-buckets-with-dns-subdomain-style branch 12 times, most recently from 54b866b to b4421f5 Compare May 30, 2024 07:30
@dahorak dahorak force-pushed the ocsqe-2099-access-buckets-with-dns-subdomain-style branch from b4421f5 to 0bb87f5 Compare May 30, 2024 10:50
@dahorak dahorak marked this pull request as ready for review May 30, 2024 10:53
@dahorak dahorak requested a review from a team as a code owner May 30, 2024 10:53
@dahorak dahorak force-pushed the ocsqe-2099-access-buckets-with-dns-subdomain-style branch from 0bb87f5 to 7841087 Compare May 30, 2024 10:54
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: acceptance
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job state: ABORTED.

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: acceptance
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: acceptance
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

@udaysk23 udaysk23 linked an issue May 31, 2024 that may be closed by this pull request
@dahorak dahorak force-pushed the ocsqe-2099-access-buckets-with-dns-subdomain-style branch from b0a8bf1 to f89b7f7 Compare June 13, 2024 06:19
@dahorak
Copy link
Contributor Author

dahorak commented Jul 16, 2024

Tested the functionality of this PR via following dummy test:

from ocs_ci.framework.testlib import acceptance

@acceptance
def test_require_virtual_hosts_for_rgw(virtual_host_style_acess_for_rgw_session):
    """
    dummy test
    """
    assert True, "dummy test"

@dahorak dahorak marked this pull request as ready for review July 16, 2024 07:00
petr-balogh
petr-balogh previously approved these changes Jul 23, 2024
Copy link

openshift-ci bot commented Aug 19, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dahorak

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dahorak

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dahorak
Copy link
Contributor Author

dahorak commented Aug 19, 2024

Just rebased and resolved conflict.

@dahorak dahorak force-pushed the ocsqe-2099-access-buckets-with-dns-subdomain-style branch from c7805dd to e9f9df8 Compare October 7, 2024 05:53
@dahorak dahorak force-pushed the ocsqe-2099-access-buckets-with-dns-subdomain-style branch 3 times, most recently from 52667f7 to bb70cc5 Compare October 11, 2024 08:27
@dahorak dahorak force-pushed the ocsqe-2099-access-buckets-with-dns-subdomain-style branch from bb70cc5 to 39fc856 Compare November 1, 2024 11:09
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase size/L PR that changes 100-499 lines team/ecosystem Ecosystem team related issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of DNS for ODF cluster
5 participants