-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure CoreDNS for enabling access to buckets with DNS subdomain style (Virtual Host style) #9839
base: master
Are you sure you want to change the base?
Conversation
54b866b
to
b4421f5
Compare
b4421f5
to
0bb87f5
Compare
0bb87f5
to
7841087
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unknown PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: acceptance
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master
Job state: ABORTED.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: acceptance
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: acceptance
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master
Job UNSTABLE (some or all tests failed).
b0a8bf1
to
f89b7f7
Compare
Tested the functionality of this PR via following dummy test: from ocs_ci.framework.testlib import acceptance
@acceptance
def test_require_virtual_hosts_for_rgw(virtual_host_style_acess_for_rgw_session):
"""
dummy test
"""
assert True, "dummy test" |
ad92b0c
to
c7805dd
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dahorak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dahorak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Just rebased and resolved conflict. |
c7805dd
to
e9f9df8
Compare
52667f7
to
bb70cc5
Compare
…access Signed-off-by: Daniel Horak <[email protected]>
Signed-off-by: Daniel Horak <[email protected]>
bb70cc5
to
39fc856
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Adding new fixture
virtual_host_style_acess_for_rgw_session
which configures the CoreDNS used for accessing buckets with DNS subdomain style.Related to https://url.corp.redhat.com/192db17