Test noobaa db activitylogs table for unnecessary logs when in default log level #9720
Conversation
PrasadDesala
added
team/e2e
| sync_object_directory( | ||
| awscli_pod_session, AWSCLI_TEST_OBJ_DIR, full_objectpath, mcg_obj | ||
| ) | ||
| logger.info("uploaded objects to the bucket") |
There was a problem hiding this comment.
how many objects will it upload?
There was a problem hiding this comment.
actually im not sure. its everything that is present in the /test_objects directory
| ), "Object deletion event is being logged in activitylogs table" | ||
| logger.info( | ||
| "No object upload/deletion info is being updated in the activitylogs table" | ||
| ) |
There was a problem hiding this comment.
there is no need to check for the DB activitylogs size?
There was a problem hiding this comment.
Nope. we only need to make sure that the activity logs doesn't include the updates for simplest operations like object upload/delete when the log level is at default mode. size of the logs can be subjective and there is no parameter to benchmark it.
|
I would suggest to upload and delete a large number of objects and check the activitylogs size after the operation to ensure the activitylogs size doesn't grow intensively. |
I dont think this is needed because the aim of the fix was to eliminate the activity logs pertaining to object upload, delete etc. It doesn't matter how many number of objects you upload. |
|
Please add a validation run for the new test |
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
Signed-off-by: Mahesh Shetty <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: keesturam, mashetty330, PrasadDesala The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: mashetty-vmj221
Cluster Configuration:
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_write_to_bucket.py::TestBucketIO::test_nb_db_activity_logs_on_io
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master
This PR automates
https://bugzilla.redhat.com/show_bug.cgi?id=2264480
https://bugzilla.redhat.com/show_bug.cgi?id=2259189