Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log based replication deletion #9660

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

mashetty330
Copy link
Contributor

@mashetty330 mashetty330 commented Apr 10, 2024

The fix for this bug https://bugzilla.redhat.com/show_bug.cgi?id=2266805 requires us to remove the replication policy by setting replicationPolicy: "". And also some other minor fixes

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-ibm8
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_6w.yaml
PR Test Suite:
PR Test Path: tests/cross_functional/system_test/test_mcg_replication_with_disruptions.py::TestLogBasedReplicationWithDisruptions
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-ibm8
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_6w.yaml
PR Test Suite:
PR Test Path: tests/cross_functional/system_test/test_mcg_replication_with_disruptions.py::TestLogBasedReplicationWithDisruptions
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines and removed size/XS labels Apr 10, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-ibm8
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_6w.yaml
PR Test Suite:
PR Test Path: tests/cross_functional/system_test/test_mcg_replication_with_disruptions.py::TestLogBasedReplicationWithDisruptions
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job UNSTABLE (some or all tests failed).

@pull-request-size pull-request-size bot added size/XS and removed size/S PR that changes 10-29 lines labels Apr 10, 2024
@mashetty330 mashetty330 self-assigned this Apr 10, 2024
@mashetty330 mashetty330 added team/e2e E2E team related issues/PRs MCG Multi Cloud Gateway / NooBaa related issues Squad/Red labels Apr 10, 2024
@mashetty330 mashetty330 marked this pull request as ready for review April 10, 2024 14:05
@mashetty330 mashetty330 requested review from a team as code owners April 10, 2024 14:05
@mashetty330 mashetty330 changed the title fix log based replication deletion Fix log based replication deletion Apr 10, 2024
Copy link

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mashetty330, OdedViner, PrasadDesala

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: mashetty-ibm8
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_6w.yaml
PR Test Suite:
PR Test Path: tests/cross_functional/system_test/test_mcg_replication_with_disruptions.py::TestLogBasedReplicationWithDisruptions
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@mashetty330 mashetty330 added the Verified Mark when PR was verified and log provided label Apr 12, 2024
@PrasadDesala PrasadDesala merged commit 5b1de2e into red-hat-storage:master Apr 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm MCG Multi Cloud Gateway / NooBaa related issues size/XS Squad/Red team/e2e E2E team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants