Fix test_odf_storagesystems_ui #9656
Conversation
Signed-off-by: Elena Bondarenko <[email protected]>
Signed-off-by: Elena Bondarenko <[email protected]>
pull-request-size
bot
added
size/S
Signed-off-by: Elena Bondarenko <[email protected]>
Signed-off-by: Elena Bondarenko <[email protected]>
Signed-off-by: Elena Bondarenko <[email protected]>
|
Fixes #9580 |
ebondare
added
Squad/Black
ocs_ci/ocs/ui/views.py
Outdated
| @@ -1369,12 +1369,17 @@ | |||
| By.XPATH, | |||
| ), | |||
| "odf-performanceCardLink": ( | |||
| "td[class='pf-u-w-10 performanceCard--verticalAlign'] a", | |||
| "td[class='pf-u-w-10 performanceCard--verticalAlign'] a, " | |||
| "td[class='pf-v5-c-table__td pf-v5-u-w-10 performanceCard--verticalAlign'] a", | |||
There was a problem hiding this comment.
CSS_Selector is too long, is there any other locator available which is short but robust?
There was a problem hiding this comment.
Actually you're right, I can just replace it with class*='performanceCard--verticalAlign'. Thank you. Fixed
There was a problem hiding this comment.
this is one class name pf-v5-c-table__td pf-v5-u-w-10 performanceCard--verticalAlign as far as I see, so it will not make difference if we use long class name or short class name
Signed-off-by: Elena Bondarenko <[email protected]>
ebondare
dismissed stale reviews from fbalak, am-agrawa, and DanielOsypenko
via
37930ce
|
Successful test run with the latest changes: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/36183/testReport/ |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DanielOsypenko, ebondare, fbalak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adjusts locators to fix test_dashboard_validation_ui, test_odf_storagesystems_ui, test_odf_cephblockpool_compression_status.