Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to automate validation of performance profiles and change the performance profiles post deployment #9490

Merged
merged 8 commits into from
Jun 6, 2024

Conversation

pintojoy
Copy link
Contributor

@pintojoy pintojoy commented Mar 15, 2024

This automates test cases from RHSTOR-4547

…formance profiles post deployment

This automates test cases from RHSTOR-4547

Signed-off-by: pintojoy <[email protected]>
@pintojoy pintojoy self-assigned this Mar 15, 2024
@pintojoy pintojoy requested a review from a team as a code owner March 15, 2024 10:38
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Mar 15, 2024
@pintojoy pintojoy changed the title [WIP} Test to automate validation ofperformance profiles and change the performance profiles post deployment [WIP} Test to automate validation of performance profiles and change the performance profiles post deployment Mar 15, 2024
@pintojoy pintojoy changed the title [WIP} Test to automate validation of performance profiles and change the performance profiles post deployment [WIP] Test to automate validation of performance profiles and change the performance profiles post deployment Mar 18, 2024
@pintojoy pintojoy changed the title [WIP] Test to automate validation of performance profiles and change the performance profiles post deployment Test to automate validation of performance profiles and change the performance profiles post deployment Mar 18, 2024
@ramkiperiy
Copy link
Contributor

ramkiperiy commented Mar 19, 2024

@pintojoy Is this a common test to validate any of the profile change?, from TC name it looks like its common test or is it specific to one particular profile.

@pintojoy
Copy link
Contributor Author

@pintojoy Is this a common test to validate any of the profile change?, from TC name it looks like its common test or is it specific to one particular profile.

@ramkiperiy Its a common test.. if the selected profile is differnet than existing profile, profile change takes place

@ramkiperiy
Copy link
Contributor

@pintojoy If validation passed could you add Verified Label?

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name: jopinto-perfibm
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py::TestProfileDefaultValuesCheck::test_change_cluster_resource_profile[lean]
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: jopinto-prof
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py::TestProfileDefaultValuesCheck::test_change_cluster_resource_profile[lean]
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job PASSED.

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: jopinto-prof
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py::TestProfileDefaultValuesCheck::test_validate_cluster_resource_profile
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job PASSED.

@pintojoy
Copy link
Contributor Author

Both the test are verified via PR validation jobs. Adding verified marker

@pintojoy pintojoy added the Verified Mark when PR was verified and log provided label Mar 28, 2024
@pintojoy pintojoy requested a review from ramkiperiy March 28, 2024 15:26
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: jopinto-prof
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py::TestProfileDefaultValuesCheck::test_validate_cluster_resource_profile
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: jopinto-prof
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py::TestProfileDefaultValuesCheck::test_validate_cluster_resource_profile
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job UNSTABLE (some or all tests failed).

@ramkiperiy
Copy link
Contributor

@pintojoy you need to resolve python 3.9 related checks, for the PR to get merged

pintojoy added 2 commits April 2, 2024 15:58
Signed-off-by: pintojoy <[email protected]>
Signed-off-by: pintojoy <[email protected]>
Comment on lines 109 to 112
pytest.param(*["performance"], marks=pytest.mark.polarion_id("OCS-XXXX")),
pytest.param(*["lean"], marks=pytest.mark.polarion_id("OCS-XXXX")),
pytest.param(*["balanced"], marks=pytest.mark.polarion_id("OCS-XXXX")),
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add polarion ID for the tests

@pintojoy pintojoy requested a review from a team as a code owner May 21, 2024 15:56
Copy link
Contributor

@ypersky1980 ypersky1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pintojoy, ramkiperiy, yitzhak12, ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ramkiperiy ramkiperiy merged commit f79ebd5 into red-hat-storage:master Jun 6, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/L PR that changes 100-499 lines Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants