-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test to automate validation of performance profiles and change the performance profiles post deployment #9490
Conversation
…formance profiles post deployment This automates test cases from RHSTOR-4547 Signed-off-by: pintojoy <[email protected]>
Signed-off-by: pintojoy <[email protected]>
Signed-off-by: pintojoy <[email protected]>
@pintojoy Is this a common test to validate any of the profile change?, from TC name it looks like its common test or is it specific to one particular profile. |
@ramkiperiy Its a common test.. if the selected profile is differnet than existing profile, profile change takes place |
tests/functional/z_cluster/test_performance_profile_validation.py
Outdated
Show resolved
Hide resolved
@pintojoy If validation passed could you add Verified Label? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name: jopinto-perfibm
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py::TestProfileDefaultValuesCheck::test_change_cluster_resource_profile[lean]
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master
Job FAILED (installation failed, tests not executed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: jopinto-prof
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py::TestProfileDefaultValuesCheck::test_change_cluster_resource_profile[lean]
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master
Signed-off-by: pintojoy <[email protected]>
Signed-off-by: pintojoy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: jopinto-prof
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py::TestProfileDefaultValuesCheck::test_validate_cluster_resource_profile
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master
Both the test are verified via PR validation jobs. Adding verified marker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: jopinto-prof
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py::TestProfileDefaultValuesCheck::test_validate_cluster_resource_profile
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master
Job UNSTABLE (some or all tests failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: jopinto-prof
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/z_cluster/test_performance_profile_validation.py::TestProfileDefaultValuesCheck::test_validate_cluster_resource_profile
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master
Job UNSTABLE (some or all tests failed).
@pintojoy you need to resolve python 3.9 related checks, for the PR to get merged |
Signed-off-by: pintojoy <[email protected]>
Signed-off-by: pintojoy <[email protected]>
pytest.param(*["performance"], marks=pytest.mark.polarion_id("OCS-XXXX")), | ||
pytest.param(*["lean"], marks=pytest.mark.polarion_id("OCS-XXXX")), | ||
pytest.param(*["balanced"], marks=pytest.mark.polarion_id("OCS-XXXX")), | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add polarion ID for the tests
Signed-off-by: pintojoy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pintojoy, ramkiperiy, yitzhak12, ypersky1980 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This automates test cases from RHSTOR-4547