Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore 'check if MCG root secret is public' if we use MS #9288

Conversation

yitzhak12
Copy link
Contributor

Currently, the MS deployment failed with the error:

2024-02-05 14:39:15 12:39:14 - MainThread - ocs_ci.ocs.ocp - WARNING - Failed to get resource: noobaa-endpoint of kind: Deployment, selector: None, Error: Error during execution of command: oc --kubeconfig /home/jenkins/current-cluster-dir/openshift-cluster-dir/auth/kubeconfig -n openshift-storage get Deployment noobaa-endpoint -n openshift-storage -o yaml.
2024-02-05 14:39:15 Error is Error from server (NotFound): deployments.apps "noobaa-endpoint" not found

See, for example, the failed deployment here: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/33416/console.
We need to remove the check in the function check_if_mcg_root_secret_public.

@yitzhak12 yitzhak12 added the Managed Services Managed Services related issues/PR label Feb 5, 2024
@yitzhak12 yitzhak12 requested a review from a team as a code owner February 5, 2024 16:03
@yitzhak12
Copy link
Contributor Author

I successfully deployed a multicluster job using the PR: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-odf-multicluster/2340/

@yitzhak12 yitzhak12 added the Verified Mark when PR was verified and log provided label Feb 6, 2024
Copy link

openshift-ci bot commented Feb 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fbalak, suchita-g, yitzhak12

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fbalak fbalak merged commit 27a1245 into red-hat-storage:master Feb 8, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Managed Services Managed Services related issues/PR size/XS Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants