Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure baremetal configuration - backport 4.13 #9282

Conversation

dahorak
Copy link
Contributor

@dahorak dahorak commented Feb 5, 2024

This is backport of #9274

Move BM configuraiton from AUTH"[baremetal"] and AUTH["ipmi"] to ENV_DATA["baremetal"] and ENV_DATA["baremetal"]["servers"] respectively.

This is just cosmetic change, but I think it will make the code and config little bit more readable and clean. (Right now for example the AUTH["ipmi"] section contains also information about the network configuration of the server (IP, MAC,...) and disks, so I think it make more sense to name the section differently and also have all the configuration related to the particular baremetal environment in one section (ENV_DATA["baremetal"]).

The configuration now looks like this:

ENV_DATA:
  baremetal:
    bm_private_nic: "..."
    bm_httpd_server: "..."
    bm_httpd_server_vm: "..."
    bm_path_to_upload: "..."
    bm_install_files: "..."
    bm_httpd_server_user: "..."
    bm_tftp_base_dir: "..."
    bm_tftp_dir: "..."
    bm_dnsmasq_dir: "..."
    bm_status_check: "..."
    bm_provisioner: "..."
    bm_provisioner_user: "..."
    servers:
      host001.example.com:
        mgmt_console: '...'
        mgmt_username: '...'
        mgmt_password: '...'
        role: '...'
        cluster_name: '...'
        public_mac: '...'
        private_mac: '...'
        ip: '...'
        root_disk_id: '...'
      host002.example.com:
        mgmt_console: '...'
        mgmt_username: '...'
        mgmt_password: '...'
        role: '...'
        cluster_name: '...'
        public_mac: '...'
        private_mac: '...'
        ip: '...'
        root_disk_id: '...'
      ...

This PR has to be merged together with respective MR in ocs4-jenkins repo.

- move BM configuraiton from AUTH"[baremetal"] and AUTH["ipmi"] to
  ENV_DATA["baremetal"] and ENV_DATA["baremetal"]["servers"] respectively

backport of red-hat-storage#9274

Signed-off-by: Daniel Horak <[email protected]>
@dahorak dahorak added the team/ecosystem Ecosystem team related issues/PRs label Feb 5, 2024
@dahorak dahorak self-assigned this Feb 5, 2024
@dahorak dahorak requested a review from a team as a code owner February 5, 2024 14:46
Copy link

openshift-ci bot commented Feb 5, 2024

@dahorak: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

restructure baremetal configuration - backport 4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Feb 5, 2024
@dahorak
Copy link
Contributor Author

dahorak commented Feb 6, 2024

Verification job: https://url.corp.redhat.com/0961033 result: SUCCESS

@dahorak dahorak added the Verified Mark when PR was verified and log provided label Feb 6, 2024
@dahorak dahorak requested a review from prsurve February 6, 2024 09:42
Copy link

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dahorak, petr-balogh, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dahorak dahorak merged commit b62b294 into red-hat-storage:release-4.13 Feb 12, 2024
5 of 6 checks passed
@dahorak dahorak deleted the restructure-baremetal-config-release-4.13 branch February 12, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/L PR that changes 100-499 lines team/ecosystem Ecosystem team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants