Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update assisted_installer code base on recent changes in api #9279

Conversation

dahorak
Copy link
Contributor

@dahorak dahorak commented Feb 5, 2024

This fix is related/similar to PR #9234, but in this case it is about response from Assisted installer API.

@dahorak dahorak added the team/ecosystem Ecosystem team related issues/PRs label Feb 5, 2024
@dahorak dahorak self-assigned this Feb 5, 2024
@dahorak dahorak requested a review from a team as a code owner February 5, 2024 11:53
@dahorak
Copy link
Contributor Author

dahorak commented Feb 5, 2024

Verification job: https://url.corp.redhat.com/239d6e5
(The respective deploy job failed because of some networking issue, but destroy job properly passed the problematic part of the code.)

@dahorak dahorak added the Verified Mark when PR was verified and log provided label Feb 5, 2024
@openshift-ci openshift-ci bot added the lgtm label Feb 6, 2024
@dahorak dahorak requested review from prsurve and amr1ta and removed request for prsurve February 6, 2024 09:42
Copy link
Contributor

@amr1ta amr1ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

Copy link

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amr1ta, dahorak, petr-balogh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dahorak dahorak merged commit b178d7f into red-hat-storage:master Feb 6, 2024
5 of 6 checks passed
@dahorak dahorak deleted the fix-assisted-installer-destroy-process branch February 6, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XS team/ecosystem Ecosystem team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants