New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV automation: Classes and helper functions - Virtctl, VirtualMachine, VirtualMachineInstance and VM workloads #9248

Merged

PrasadDesala merged 15 commits into red-hat-storage:master from PrasadDesala:cnv_vm_and_io

Feb 27, 2024

Contributor

PrasadDesala commented Jan 30, 2024 •

edited

Loading

OpenShift Virtualization (CNV) is an add-on to OCP that allows running and managing virtual machine workloads alongside container workloads. The ODF can be used in conjunction with CNV to provide persistent storage for virtual machines.

This PR handles creation of necessary classes and helper functions for VM workload management.

Virtctl - Virtctl is a commandline utility used for managing and interacting with virtual machines in a Kubernetes cluster. It provides a set of commands to control virtual machines such as starting, stopping, SSH, SCP and obtaining information about a VM.
VirtualMachine - VirtualMachine is a Kubernetes CR representing a virtual machine. It defines the desired state and configuration
VirtualMachineInstance - VirtualMachine is a Kubernetes CR representing a virtual machine instance. It represents an instance of a virtual machine
VM referenced by a standalone PVC
VM workload - Centos


          CNV automation: Classes and helper functions - Virtctl, VirtualMachin…

e248aff

…e, VirtualMachineInstance and VM workloads

Signed-off-by: Prasad Desala <[email protected]>

PrasadDesala added the team/e2e label

PrasadDesala self-assigned this

PrasadDesala requested a review from a team as a code owner

January 30, 2024 07:32

pull-request-size bot added the size/XXL label

openshift-ci bot added the do-not-merge/work-in-progress label

avd-sagare reviewed

View reviewed changes

ocs_ci/helpers/cnv_helpers.py Outdated Show resolved Hide resolved


          added code for create secret to connect to vm and wait for the ssh co…

5f2fb44

…nnectivity

Signed-off-by: Prasad Desala <[email protected]>

PrasadDesala changed the title ~~[WIP] CNV automation: Classes and helper functions - Virtctl, VirtualMachine, VirtualMachineInstance and VM workloads~~ CNV automation: Classes and helper functions - Virtctl, VirtualMachine, VirtualMachineInstance and VM workloads

openshift-ci bot removed the do-not-merge/work-in-progress label


          remove accessCredentials details from fedora vm yaml

fbb2b7b

Signed-off-by: Prasad Desala <[email protected]>

kgoldbla suggested changes

View reviewed changes

ocs_ci/helpers/cnv_helpers.py Outdated Show resolved Hide resolved

ocs_ci/templates/cnv-vm-workload/vm_fedora.yaml Outdated Show resolved Hide resolved

ocs_ci/templates/cnv-vm-workload/vm_centos.yaml Outdated Show resolved Hide resolved

openshift-ci bot commented Feb 8, 2024

@kgoldbla: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PrasadDesala added 2 commits

February 19, 2024 16:37


          replaced the use of the datavolume to use standalone pvc + added cnv …

c4a86c6

…basic tests + few enhancements

Signed-off-by: Prasad Desala <[email protected]>


          doc string fix

56012b5

Signed-off-by: Prasad Desala <[email protected]>

PrasadDesala requested a review from parikshithb

February 19, 2024 12:09

parikshithb previously approved these changes

View reviewed changes

Contributor

parikshithb left a comment

lgtm

openshift-ci bot assigned parikshithb

openshift-ci bot added the lgtm label


          added teardown for basic cnv tests

Signed-off-by: Prasad Desala <[email protected]>

PrasadDesala dismissed parikshithb’s stale review via

February 19, 2024 17:16

openshift-ci bot removed the lgtm label

PrasadDesala added 2 commits

February 19, 2024 23:13


          fix spacing issue in test function

0021ee2

Signed-off-by: Prasad Desala <[email protected]>


          small fix

a7edb20

Signed-off-by: Prasad Desala <[email protected]>

ocs-ci reviewed

View reviewed changes

ocs-ci left a comment

PR validation on existing cluster

Cluster Name: tdesala-feb19
Cluster Configuration:
PR Test Suite: workloads
PR Test Path: tests/functional/workloads/cnv
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job UNSTABLE (some or all tests failed).


          use -i ssh_private_key_path during ssh,scp and get the ssh_key from o…

e49c562

…cs-ci framework if present

Signed-off-by: Prasad Desala <[email protected]>

ocs-ci reviewed

View reviewed changes

ocs-ci left a comment

PR validation on existing cluster

Cluster Name: tdesala-feb19
Cluster Configuration:
PR Test Suite: workloads
PR Test Path: tests/functional/workloads/cnv
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job UNSTABLE (some or all tests failed).


          small fix

ef671ed

Signed-off-by: Prasad Desala <[email protected]>

ocs-ci reviewed

View reviewed changes

ocs-ci left a comment

PR validation on existing cluster

Cluster Name: tdesala-feb19
Cluster Configuration:
PR Test Suite: workloads
PR Test Path: tests/functional/workloads/cnv
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master


          move get_ssh_private_key_path to cnv_helpers.py

2d653cc

Signed-off-by: Prasad Desala <[email protected]>


          small fix

b9d490c

Signed-off-by: Prasad Desala <[email protected]>

ocs-ci reviewed

View reviewed changes

ocs-ci left a comment

PR validation on existing cluster

Cluster Name: tdesala-feb19
Cluster Configuration:
PR Test Suite: workloads
PR Test Path: tests/functional/workloads/cnv
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job UNSTABLE (some or all tests failed).


          expanduser after getting the ssh_key

a6aa848

Signed-off-by: Prasad Desala <[email protected]>

ocs-ci reviewed

View reviewed changes

ocs-ci left a comment

PR validation on existing cluster

Cluster Name: tdesala-feb18
Cluster Configuration:
PR Test Suite: workloads
PR Test Path: tests/functional/workloads/cnv
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci reviewed

View reviewed changes

ocs-ci left a comment

PR validation on existing cluster

Cluster Name: tdesala-feb19
Cluster Configuration:
PR Test Suite: workloads
PR Test Path: tests/functional/workloads/cnv
Additional Test Params:
OCP VERSION: 4.15
OCS VERSION: 4.15
tested against branch: master

PrasadDesala added the Verified label

PrasadDesala requested a review from shylesh

February 21, 2024 10:26

kgoldbla suggested changes

View reviewed changes

ocs_ci/helpers/cnv_helpers.py Outdated Show resolved Hide resolved

ocs_ci/templates/cnv-vm-workload/vm-standalone-pvc/vm.yaml Show resolved Hide resolved

tests/functional/workloads/cnv/test_vm_lifecycle_and_io.py Show resolved Hide resolved

tests/functional/workloads/cnv/test_vm_lifecycle_and_io.py Show resolved Hide resolved

tests/functional/workloads/cnv/test_vm_single_disk_hot_plugging_unplugging.py Show resolved Hide resolved

openshift-ci bot commented Feb 21, 2024

@kgoldbla: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


          fix doc string

7a38b8b

Signed-off-by: Prasad Desala <[email protected]>

shylesh reviewed

View reviewed changes

ocs_ci/helpers/cnv_helpers.py Show resolved Hide resolved

ocs_ci/ocs/cnv/virtctl.py Outdated Show resolved Hide resolved

ocs_ci/templates/cnv-vm-workload/vm-standalone-pvc/vm.yaml Show resolved Hide resolved

ocs_ci/ocs/cnv/virtual_machine_instance.py Show resolved Hide resolved


          fix doc string

b576431

Signed-off-by: Prasad Desala <[email protected]>

shylesh approved these changes

View reviewed changes

Contributor

shylesh left a comment

LGTM

openshift-ci bot assigned shylesh

openshift-ci bot added the lgtm label

parikshithb approved these changes

View reviewed changes

openshift-ci bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: parikshithb, PrasadDesala, shylesh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

PrasadDesala merged commit 00f4c1b into red-hat-storage:master

5 of 6 checks passed

prsurve pushed a commit to prsurve/ocs-ci that referenced this pull request


          CNV automation: Classes and helper functions - Virtctl, VirtualMachin…

bd282d9

…e, VirtualMachineInstance and VM workloads (red-hat-storage#9248)

Signed-off-by: Prasad Desala <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ocs-ci ocs-ci left review comments

avd-sagare avd-sagare left review comments

kgoldbla kgoldbla requested changes

parikshithb parikshithb approved these changes

shylesh shylesh approved these changes

Labels

lgtm size/XXL team/e2e Verified