Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that default noobaa backingstore uses rgw endpoint on provider #9243

Merged
merged 6 commits into from
Jan 31, 2024

Conversation

fbalak
Copy link
Contributor

@fbalak fbalak commented Jan 29, 2024

Verifies that default noobaa backingstore uses rgw endpoint on provider

@fbalak fbalak added Squad/Red provider-client Provider-client solution labels Jan 29, 2024
@fbalak fbalak self-assigned this Jan 29, 2024
@fbalak fbalak requested a review from a team as a code owner January 29, 2024 13:54
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Jan 29, 2024
Signed-off-by: fbalak <[email protected]>
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines and removed size/S PR that changes 10-29 lines labels Jan 30, 2024
Signed-off-by: fbalak <[email protected]>
@fbalak
Copy link
Contributor Author

fbalak commented Jan 30, 2024

@fbalak fbalak added the Verified Mark when PR was verified and log provided label Jan 30, 2024
Copy link
Contributor

@sagihirshfeld sagihirshfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM regarding the the implementation itself, but I suggest putting this test under a separate test file that will be dedicated for provider-client MCG/RGW tests.

DanielOsypenko
DanielOsypenko previously approved these changes Jan 31, 2024
Copy link

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dahorak, fbalak, sagihirshfeld

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fbalak fbalak merged commit 05a7bb5 into red-hat-storage:master Jan 31, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm provider-client Provider-client solution size/M PR that changes 30-99 lines Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants