Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bare metal deployment: create BAREMETALBASE class #9237

Merged

Conversation

dahorak
Copy link
Contributor

@dahorak dahorak commented Jan 26, 2024

There shouldn't be any functional change in this PR, it is just separation of common functionality for BM deployment to BAREMETALBASE class.
This will help with further development of IPI deployment or deployment via Assisted Installer.

@dahorak dahorak added the team/ecosystem Ecosystem team related issues/PRs label Jan 26, 2024
@dahorak dahorak self-assigned this Jan 26, 2024
@dahorak dahorak requested a review from a team as a code owner January 26, 2024 11:25
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Jan 26, 2024
@dahorak dahorak force-pushed the baremetal-base-deployment-class branch from dc9839e to 211a102 Compare January 26, 2024 11:26
- separate common functionality for BM deployment to BAREMETALBASE class

Signed-off-by: Daniel Horak <[email protected]>
@dahorak dahorak force-pushed the baremetal-base-deployment-class branch from 211a102 to a2d59b6 Compare January 26, 2024 12:44
@dahorak
Copy link
Contributor Author

dahorak commented Jan 26, 2024

Verification job: https://url.corp.redhat.com/07091f5

@dahorak
Copy link
Contributor Author

dahorak commented Jan 26, 2024

Verification job passed.

@dahorak dahorak added the Verified Mark when PR was verified and log provided label Jan 26, 2024
@openshift-ci openshift-ci bot added the lgtm label Jan 29, 2024
@dahorak dahorak requested a review from prsurve January 29, 2024 06:52
Copy link

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dahorak, prsurve, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dahorak dahorak merged commit ce1f96f into red-hat-storage:master Jan 29, 2024
5 of 6 checks passed
@dahorak dahorak deleted the baremetal-base-deployment-class branch January 29, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/L PR that changes 100-499 lines team/ecosystem Ecosystem team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants