-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bare metal deployment: create BAREMETALBASE class #9237
Merged
dahorak
merged 3 commits into
red-hat-storage:master
from
dahorak:baremetal-base-deployment-class
Jan 29, 2024
Merged
Bare metal deployment: create BAREMETALBASE class #9237
dahorak
merged 3 commits into
red-hat-storage:master
from
dahorak:baremetal-base-deployment-class
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahorak
force-pushed
the
baremetal-base-deployment-class
branch
from
January 26, 2024 11:26
dc9839e
to
211a102
Compare
- separate common functionality for BM deployment to BAREMETALBASE class Signed-off-by: Daniel Horak <[email protected]>
dahorak
force-pushed
the
baremetal-base-deployment-class
branch
from
January 26, 2024 12:44
211a102
to
a2d59b6
Compare
Signed-off-by: Daniel Horak <[email protected]>
Signed-off-by: Daniel Horak <[email protected]>
Verification job: https://url.corp.redhat.com/07091f5 |
Verification job passed. |
vavuthu
approved these changes
Jan 29, 2024
prsurve
approved these changes
Jan 29, 2024
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dahorak, prsurve, vavuthu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm
size/L
PR that changes 100-499 lines
team/ecosystem
Ecosystem team related issues/PRs
Verified
Mark when PR was verified and log provided
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There shouldn't be any functional change in this PR, it is just separation of common functionality for BM deployment to
BAREMETALBASE
class.This will help with further development of IPI deployment or deployment via Assisted Installer.