Create the node functionalities for IBMCloud with Bare Metal #9202
Conversation
yitzhak12
force-pushed
the
add-hci-baremetal-node-platform-functionalities
branch
2 times, most recently
from
38b020f to
514ceea
Compare
pull-request-size
bot
added
size/XL
and removed
size/L
yitzhak12
changed the title
yitzhak12
force-pushed
the
add-hci-baremetal-node-platform-functionalities
branch
2 times, most recently
from
6b0e84d to
7e8798c
Compare
…le for testing the node restart functionalities, Add a new marker 'provider_client_platform_required' Signed-off-by: Itzhak Kave <[email protected]>
yitzhak12
force-pushed
the
add-hci-baremetal-node-platform-functionalities
branch
from
7e8798c to
1a7cb46
Compare
|
I successfully ran a PR validation job on two tests: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/33288/ |
yitzhak12
requested review from
ebenahar,
fbalak,
jilju,
ebondare,
DanielOsypenko,
amr1ta and
suchita-g
|
hello @yitzhak12. This would not be an ODF tests, but the tests for IBM Cloud BM interface and infrastructure. May I advice to move them to lib tests to avoid effecting 4a, 4b test runs. |
Those tests look like valid tier4 tests to me. Test scenarios are done on clusters with installed odf and the storage health that can be affected by those scenarios is checked after each operation. |
ocs_ci/ocs/constants.py
Outdated
| @@ -2434,3 +2434,6 @@ | |||
| OPERATION_START = "start" | |||
| OPERATION_RESTART = "restart" | |||
| OPERATION_TERMINATE = "terminate" | |||
|
|
|||
| # HCI Bare Metal platform | |||
| HCI_BAREMETAL_DEFAULT_REGION = "us-east" | |||
There was a problem hiding this comment.
It would be better to get this value from config.
| ), | ||
| ], | ||
| ) | ||
| def test_nodes_restart_by_stop_and_start(self, cluster_type, nodes, node_type): |
| pytest.param(*[HCI_PROVIDER, constants.WORKER_MACHINE]), | ||
| ], | ||
| ) | ||
| def test_node_maintenance_restart(self, cluster_type, nodes, node_type): |
- add one Polarion ID, and create two new Polarion IDs - Add the 'region' param to the config file - Increase timeout waiting for the pods - Fix the init method of the class 'IBMCloudBM' Signed-off-by: Itzhak Kave <[email protected]>
|
I re-run a PR validation job, and it passed: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/33401 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DanielOsypenko, fbalak, yitzhak12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I successfully deployed an AWS 4.15 cluster using the PR: https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/33411/ |
Create the node functionalities for IBMCloud with Bare Metal.
I used the IBM docs: https://cloud.ibm.com/docs/cli?topic=cli-sl-manage-bare-metal.
In this PR, I implemented the following:
IBMCloudBMNodes, in the platform_nodes file for HCI IBMCloud with Bare Metal.ocs_ci/utility/ibmcloud_bm.py, for HCI IBMCloud with Bare Metal.tests/functional/z_cluster/nodes/test_nodes_restart_hci.py, for testing the node restart scenarios for HCI IBMCloud with Bare Metal.I am still not testing termination and creating new machines, as I need more information.
Also, I didn't use IO in the test file cause we still need to figure out the best way to run IO on multiple clients. I will add it in the next PR.