Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getting the "ocs-osd-removal-job" name #8879

Merged
merged 2 commits into from
Nov 25, 2023
Merged

Update getting the "ocs-osd-removal-job" name #8879

merged 2 commits into from
Nov 25, 2023

Conversation

yitzhak12
Copy link
Contributor

fix #8839

@yitzhak12 yitzhak12 requested a review from a team as a code owner November 19, 2023 16:17
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Nov 19, 2023
@yitzhak12 yitzhak12 requested a review from a team as a code owner November 20, 2023 10:44
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines and removed size/S PR that changes 10-29 lines labels Nov 20, 2023
ocs-ci
ocs-ci reviewed Nov 23, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-vm414
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job PASSED.

ocs-ci
ocs-ci reviewed Nov 23, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-vm414
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job PASSED.

@yitzhak12 yitzhak12 added the Verified Mark when PR was verified and log provided label Nov 23, 2023
amr1ta
amr1ta approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@amr1ta amr1ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@openshift-ci openshift-ci bot added the lgtm label Nov 24, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amr1ta, ebenahar, yitzhak12

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebenahar ebenahar merged commit 938cce5 into red-hat-storage:master Nov 25, 2023
5 of 6 checks passed
@yitzhak12 yitzhak12 added the cherry-pick This is cherry-pick (backport) label Nov 26, 2023
This was referenced Nov 29, 2023
Merged
Merged
ocs-ci
ocs-ci reviewed Dec 4, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-vm413
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/z_cluster/nodes/test_disk_failures.py::TestDiskFailures::test_recovery_from_volume_deletion
Additional Test Params:
OCP VERSION: 4.13
OCS VERSION: 4.13
tested against branch: release-4.13

Job FAILED (installation failed, tests not executed).

ebenahar pushed a commit that referenced this pull request Dec 12, 2023
@yitzhak12
Update getting the "ocs-osd-removal-job" name 4.13 #8879 (#8962)
2ee94a5 
Signed-off-by: Itzhak Kave <[email protected]>
ebenahar pushed a commit that referenced this pull request Dec 12, 2023
@yitzhak12
Update getting the "ocs-osd-removal-job" name 4.14 #8879 (#8964)
8697b13 
Signed-off-by: Itzhak Kave <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@amr1ta amr1ta amr1ta approved these changes

@ebenahar ebenahar ebenahar approved these changes

Assignees

@ebenahar ebenahar

@amr1ta amr1ta

Labels
cherry-pick This is cherry-pick (backport) lgtm size/M PR that changes 30-99 lines Squad/Brown Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stabilize test_recovery_from_volume_deletion for all supported ODF versions
4 participants
@yitzhak12 @ebenahar @amr1ta @ocs-ci