Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace OPENSHIFT_STORAGE_NAMESPACE and ROOK_CLUSTER_NAMESPACE usage with configuration #8854

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

@fbalak fbalak self-assigned this Nov 15, 2023
@fbalak fbalak requested review from a team as code owners November 15, 2023 14:28
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Nov 15, 2023
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

@fbalak
Copy link
Contributor Author

fbalak commented Nov 16, 2023

Errors from the tier1 PR validation are not caused by the namespace invokation change.

@fbalak fbalak added the Verified Mark when PR was verified and log provided label Nov 16, 2023
Copy link

openshift-ci bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DanielOsypenko, ebenahar, ebondare, fbalak, petr-balogh, suchita-g

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-balogh petr-balogh merged commit 8977201 into red-hat-storage:master Nov 16, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/L PR that changes 100-499 lines Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use config.ENV_DATA["cluster_namespace"] instead of OPENSHIFT_STORAGE_NAMESPACE and ROOK_CLUSTER_NAMESPACE
7 participants