Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repos to install google-chrome to run UI tests #8851

Closed
wants to merge 1 commit into from

Conversation

rabin-io
Copy link
Contributor

No description provided.

@rabin-io rabin-io requested a review from a team as a code owner November 15, 2023 10:43
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Nov 15, 2023
Copy link

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rabin-io

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Add extra repos to RUNNER stage
which are required to install google-chrome to run UI tests

Signed-off-by: Rabin Yasharzadehe <[email protected]>

RUN dnf install -y --nodocs python38 git jq rsync make \
# Install EPEL repos
# RUN dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm https://dl.fedoraproject.org/pub/epel/epel-next-release-latest-8.noarch.rpm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line commented out intentionally?
If it's not needed, we can delete 2 lines above, right?

Copy link
Contributor Author

@rabin-io rabin-io Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I left them as an option to enable them if in the future we will need packages from epel, for example pulling jq and yq (or anything else in that matter) instead of downloading directly from GitHub.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the lifecycle/stale No recent activity label Feb 14, 2024
@rabin-io rabin-io closed this Feb 14, 2024
@rabin-io
Copy link
Contributor Author

Closing, as we skip UI tests in the acceptance tests.
fill free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale No recent activity size/S PR that changes 10-29 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants