Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider client platforms in on Prem Platform #8848

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

suchita-g
Copy link
Contributor

Fixes invalid skip issue #8847

@suchita-g suchita-g added the provider-client Provider-client solution label Nov 15, 2023
@suchita-g suchita-g self-assigned this Nov 15, 2023
@suchita-g suchita-g requested a review from a team as a code owner November 15, 2023 10:09
@suchita-g
Copy link
Contributor Author

suchita-g commented Nov 15, 2023

Verification Job : https://ocs4-jenkins-csb-odf-qe.apps.ocp-c1.prod.psi.redhat.com/job/qe-odf-multicluster/2065/

Test executed and failed or error for a fixes w.r.t. hci provider client setup

@suchita-g suchita-g added the Verified Mark when PR was verified and log provided label Nov 15, 2023
Copy link
Contributor

@amr1ta amr1ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Copy link

openshift-ci bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amr1ta, dahorak, ebenahar, suchita-g

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebenahar ebenahar merged commit 772a88c into red-hat-storage:master Nov 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm provider-client Provider-client solution size/XS Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants