Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_run_pod_local_image testcase #8835

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Fix test_run_pod_local_image testcase #8835

merged 1 commit into from
Dec 4, 2023

Conversation

vkathole
Copy link
Contributor

Fixes #8794

@vkathole vkathole added team/e2e E2E team related issues/PRs Squad/Magenta labels Nov 13, 2023
@vkathole vkathole self-assigned this Nov 13, 2023
@vkathole vkathole requested a review from a team as a code owner November 13, 2023 10:21
ocs-ci
ocs-ci reviewed Nov 13, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown PR validation on existing cluster

Cluster Name: vkathole-n3
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/e2e/workloads/ocp/registry/test_pod_from_registry.py
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job state: ABORTED.

ocs-ci
ocs-ci reviewed Nov 14, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: vkathole-n14
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/e2e/workloads/ocp/registry/test_pod_from_registry.py
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job PASSED.

@openshift-ci openshift-ci bot added the lgtm label Dec 4, 2023
Shrivaibavi
Shrivaibavi approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Shrivaibavi Shrivaibavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PrasadDesala, Shrivaibavi, vkathole

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PrasadDesala PrasadDesala merged commit 5aafc04 into red-hat-storage:master Dec 4, 2023
4 of 5 checks passed
paraggit pushed a commit to paraggit/ocs-ci that referenced this pull request Dec 20, 2023
@vkathole @paraggit
Fix test_run_pod_local_image testcase (red-hat-storage#8835)
83b45bf 
Signed-off-by: Vishakha Kathole <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@Shrivaibavi Shrivaibavi Shrivaibavi approved these changes

@PrasadDesala PrasadDesala PrasadDesala approved these changes

Assignees

@PrasadDesala PrasadDesala

@Shrivaibavi Shrivaibavi

@vkathole vkathole

Labels
lgtm size/XS Squad/Magenta team/e2e E2E team related issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_run_pod_local_image fails with assertion errors and Repo not found errors
4 participants
@vkathole @PrasadDesala @Shrivaibavi @ocs-ci