Adding Markers for FUSION HCI Provider Client Platform #8824
Conversation
suchita-g
force-pushed
the
hci_pc_testmarker
branch
from
5f2f896 to
b63cd66
Compare
pull-request-size
bot
added
size/L
suchita-g
force-pushed
the
hci_pc_testmarker
branch
from
bf15e18 to
8153952
Compare
Signed-off-by: suchita-g <[email protected]>
…ider Signed-off-by: suchita-g <[email protected]>
Signed-off-by: suchita-g <[email protected]>
Signed-off-by: suchita-g <[email protected]>
suchita-g
force-pushed
the
hci_pc_testmarker
branch
from
4f17eef to
1221a13
Compare
Signed-off-by: suchita-g <[email protected]> This will fix blocker issue for provider client run red-hat-storage#8840
Signed-off-by: suchita-g <[email protected]> Fixes red-hat-storage#8841
suchita-g
requested review from
ebenahar,
petr-balogh,
fbalak,
ebondare,
amr1ta and
vavuthu
| skipif_hci_provider_and_client = pytest.mark.skipif( | ||
| config.ENV_DATA["platform"].lower() in HCI_PROVIDER_CLIENT_PLATFORMS | ||
| and config.is_hci_provider_exist() | ||
| and config.is_hci_client_exist(), |
There was a problem hiding this comment.
So the tests marked with this mark will not be skipped if run on hci provider without clients. Is it the desired behaviour? Wouldn't it be more useful to have a mark for skipping the test on any hci cluster, no matter if it's a provider, client or provider+client multicluster setup?
There was a problem hiding this comment.
This is similar to MS function
https://github.com/red-hat-storage/ocs-ci/blob/b16f17fbc17c8e774b0fec587fe4a07c3659d191/ocs_ci/framework/pytest_customization/marks.py#L338C1-L343C2
this function is also reference from MS Markers
There was a problem hiding this comment.
Also as now platform type is unique to hci , we can do this in either way
Signed-off-by: suchita-g <[email protected]>
suchita-g
dismissed stale reviews from fbalak and DanielOsypenko
via
dfdc0a3
suchita-g
force-pushed
the
hci_pc_testmarker
branch
from
765021d to
dfdc0a3
Compare
Signed-off-by: suchita-g <[email protected]>
suchita-g
dismissed stale reviews from DanielOsypenko and ebenahar
via
070cae9
suchita-g
force-pushed
the
hci_pc_testmarker
branch
from
dfdc0a3 to
070cae9
Compare
Signed-off-by: suchita-g <[email protected]>
ocs_ci/framework/__init__.py
Outdated
| @@ -13,6 +13,7 @@ | |||
| import logging | |||
| from collections.abc import Mapping | |||
| from dataclasses import dataclass, field, fields | |||
| from ocs_ci.ocs.constants import HCI_CLIENT, HCI_PROVIDER | |||
There was a problem hiding this comment.
As use of from ocs_ci.ocs.constants import HCI_CLIENT, HCI_PROVIDER lib inside init.py file causes circular import Error. with Reference to other code in init.py file , using hci_client and provider as a hardcoded value.
[58](https://github.com/red-hat-storage/ocs-ci/actions/runs/6866895930/job/18674124645?pr=8824#step:6:61)
Tue, 14 Nov 2023 19:04:00 GMT
from ocs_ci.utility.utils import get_ocp_version
[59](https://github.com/red-hat-storage/ocs-ci/actions/runs/6866895930/job/18674124645?pr=8824#step:6:62)
Tue, 14 Nov 2023 19:04:00 GMT
ocs_ci/utility/utils.py:41: in <module>
[60](https://github.com/red-hat-storage/ocs-ci/actions/runs/6866895930/job/18674124645?pr=8824#step:6:63)
Tue, 14 Nov 2023 19:04:00 GMT
from ocs_ci.framework import config
[61](https://github.com/red-hat-storage/ocs-ci/actions/runs/6866895930/job/18674124645?pr=8824#step:6:64)
Tue, 14 Nov 2023 19:04:00 GMT
E ImportError: cannot import name 'config' from partially initialized module 'ocs_ci.framework' (most likely due to a circular import) (/home/runner/work/ocs-ci/ocs-ci/ocs_ci/framework/__init__.py)```
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DanielOsypenko, ebenahar, fbalak, suchita-g The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.