Remove DRPC deletion command, as it is automatically deleted. #8799
Conversation
Signed-off-by: Sidhant Agrawal <[email protected]>
|
Verified: https://url.corp.redhat.com/21b9a28 |
| finally: | ||
| config.switch_acm_ctx() | ||
| run_cmd( | ||
| f"oc delete drpc -n {constants.GITOPS_CLUSTER_NAMESPACE} {drpc_name}" |
There was a problem hiding this comment.
Is constants.GITOPS_CLUSTER_NAMESPACE used somewhere else?
There was a problem hiding this comment.
Yes, it's being used in dr_helpers.py
|
@sidhant-agrawal Have you checked if placement is getting auto-deleted every time so that we no longer need to delete drpc? |
Yes, the placement will be deleted here. Therefore, manual deletion of DRPC not needed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: am-agrawa, jilju, prsurve, shylesh, sidhant-agrawal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #8798
The DRPC deletion command was used to delete the DRPC during ApplicationSet workload deletion. However, this command is no longer necessary, as the DRPC is now automatically deleted (BZ 2234428)
This change removes the DRPC deletion command.