-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix mgr pdb resource count #8738
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This passed downstream testing (the deployment passed). |
b-ranto
previously approved these changes
Oct 26, 2023
ebenahar
previously approved these changes
Oct 26, 2023
prsurve
reviewed
Oct 26, 2023
vavuthu
reviewed
Oct 26, 2023
parth-gr
requested review from
petr-balogh,
prsurve,
vavuthu,
ebenahar and
b-ranto
October 26, 2023 15:07
petr-balogh
previously approved these changes
Oct 26, 2023
petr-balogh
reviewed
Oct 26, 2023
from recent ocs operator changes we are trying to have more than 1 mgr by deafult, So to imply it we need to check for the mgr pdb which would get created if mgr count >1 Signed-off-by: parth-gr <[email protected]>
petr-balogh
approved these changes
Oct 26, 2023
vavuthu
approved these changes
Oct 26, 2023
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: parth-gr, petr-balogh, vavuthu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from recent ocs operator changes we are trying to
have more than 1 mgr by deafult,
So to imply it we need to check for the mgr pdb
which would get created if mgr count >1