Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix mgr pdb resource count #8738

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

parth-gr
Copy link
Member

from recent ocs operator changes we are trying to
have more than 1 mgr by deafult,
So to imply it we need to check for the mgr pdb
which would get created if mgr count >1

@b-ranto
Copy link
Member

b-ranto commented Oct 26, 2023

This passed downstream testing (the deployment passed).

b-ranto
b-ranto previously approved these changes Oct 26, 2023
ebenahar
ebenahar previously approved these changes Oct 26, 2023
ocs_ci/ocs/cluster.py Outdated Show resolved Hide resolved
ocs_ci/ocs/cluster.py Outdated Show resolved Hide resolved
@parth-gr parth-gr dismissed stale reviews from ebenahar and b-ranto via 6f68888 October 26, 2023 15:07
@openshift-ci openshift-ci bot removed the lgtm label Oct 26, 2023
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Oct 26, 2023
petr-balogh
petr-balogh previously approved these changes Oct 26, 2023
from recent ocs operator changes we are trying to
have more than 1 mgr by deafult,
So to imply it we need to check for the mgr pdb
which would get created if mgr count >1

Signed-off-by: parth-gr <[email protected]>
@openshift-ci openshift-ci bot added the lgtm label Oct 26, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: parth-gr, petr-balogh, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vavuthu vavuthu merged commit b206600 into red-hat-storage:master Oct 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/S PR that changes 10-29 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants