Modify test_respin_app_pod_exported_nfs_volume_incluster to address teardown of deployment pod and pvc #8666
Conversation
…eardown of deployment pod and pvc Updated test_respin_app_pod_exported_nfs_volume_incluster to handle deployment deletion and pvc deletion if test fails Signed-off-by: pintojoy <[email protected]>
tests/manage/nfs_feature/test_nfs_feature_enable_for_ODF_clusters.py
Outdated
Show resolved
Hide resolved
Signed-off-by: pintojoy <[email protected]>
There was a problem hiding this comment.
PR validation on existing cluster
Cluster Name: jopinto-tip414
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/manage/nfs_feature/test_nfs_feature_enable_for_ODF_clusters.py::TestNfsEnable::test_respin_app_pod_exported_nfs_volume_incluster
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master
| deployment_config = """ | ||
| apiVersion: apps.openshift.io/v1 | ||
| kind: DeploymentConfig | ||
| metadata: | ||
| name: nfs-test-pod | ||
| namespace: openshift-storage | ||
| labels: | ||
| app: nfs-test-pod | ||
| spec: | ||
| template: | ||
| metadata: | ||
| labels: | ||
| name: nfs-test-pod | ||
| spec: | ||
| restartPolicy: Always | ||
| volumes: | ||
| - name: vol | ||
| persistentVolumeClaim: | ||
| claimName: nfs-pvc | ||
| containers: | ||
| - name: fedora | ||
| image: fedora | ||
| command: ['/bin/bash', '-ce', 'tail -f /dev/null'] | ||
| imagePullPolicy: IfNotPresent | ||
| securityContext: | ||
| capabilities: {} | ||
| privileged: true | ||
| volumeMounts: | ||
| - mountPath: /mnt | ||
| name: vol | ||
| livenessProbe: | ||
| exec: | ||
| command: | ||
| - 'sh' | ||
| - '-ec' | ||
| - 'df /mnt' | ||
| initialDelaySeconds: 3 | ||
| periodSeconds: 3 | ||
| replicas: 1 | ||
| triggers: | ||
| - type: ConfigChange | ||
| paused: false | ||
| """ |
There was a problem hiding this comment.
Can this content moved to template yaml location?, so in-case of future use we can consume it.
Signed-off-by: pintojoy <[email protected]>
There was a problem hiding this comment.
PR validation
Cluster Name: jopinto-tip414
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/manage/nfs_feature/test_nfs_feature_enable_for_ODF_clusters.py::TestNfsEnable::test_respin_app_pod_exported_nfs_volume_incluster
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master
Job UNSTABLE (some or all tests failed).
Signed-off-by: pintojoy <[email protected]>
There was a problem hiding this comment.
PR validation
Cluster Name: jopinto-tip414
Cluster Configuration: conf/deployment/vsphere/ipi_1az_rhcos_vsan_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/manage/nfs_feature/test_nfs_feature_enable_for_ODF_clusters.py::TestNfsEnable::test_respin_app_pod_exported_nfs_volume_incluster
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ebenahar, pintojoy, ramkiperiy, yitzhak12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Closing this PR, will raise a new PR to address merge conflicts post directory changes |
Updated test_respin_app_pod_exported_nfs_volume_incluster to handle deployment deletion and pvc deletion if test fails. Fixes #8602