Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes mirroring timeout issue #8658

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fixes mirroring timeout issue #8658

merged 1 commit into from
Dec 12, 2023

Conversation

udaysk23
Copy link
Contributor

@udaysk23 udaysk23 commented Oct 9, 2023

Fixes #7183

@udaysk23 udaysk23 requested a review from a team as a code owner October 9, 2023 16:42
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Oct 9, 2023
@udaysk23 udaysk23 added MCG Multi Cloud Gateway / NooBaa related issues DO NOT MERGE Do not merge this change!! labels Oct 9, 2023
@udaysk23 udaysk23 force-pushed the test_multiregion_mirror branch 3 times, most recently from 9481b4c to d4af86f Compare October 9, 2023 17:19
ocs-ci
ocs-ci reviewed Oct 9, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ukurundw-13
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/mcg/test_multi_region.py::TestMultiRegion::test_multiregion_mirror
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Oct 10, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ukurundw-13
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/mcg/test_multi_region.py::TestMultiRegion::test_multiregion_mirror
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job FAILED (installation failed, tests not executed).

@udaysk23 udaysk23 added Needs Testing Run tests and provide logs link and removed DO NOT MERGE Do not merge this change!! labels Oct 10, 2023
ocs-ci
ocs-ci reviewed Oct 11, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/manage/mcg/test_multi_region.py::TestMultiRegion::test_multiregion_mirror
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Oct 12, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ukurundw-14
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/mcg/test_multi_region.py::TestMultiRegion::test_multiregion_mirror
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job PASSED.

@udaysk23 udaysk23 added Verified Mark when PR was verified and log provided and removed Needs Testing Run tests and provide logs link labels Oct 12, 2023
sagihirshfeld
sagihirshfeld previously requested changes Oct 15, 2023
View reviewed changes
ocs_ci/ocs/resources/mcg.py Outdated Show resolved Hide resolved
ocs_ci/ocs/resources/mcg.py Outdated Show resolved Hide resolved
ocs_ci/ocs/resources/mcg.py Outdated Show resolved Hide resolved
ocs_ci/ocs/resources/mcg.py Outdated Show resolved Hide resolved
ocs_ci/ocs/resources/mcg.py Outdated Show resolved Hide resolved
@udaysk23 udaysk23 force-pushed the test_multiregion_mirror branch 4 times, most recently from ef6a951 to fc77961 Compare November 6, 2023 08:19
ocs-ci
ocs-ci reviewed Nov 6, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ukurundw-21
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/mcg/test_multi_region.py::TestMultiRegion::test_multiregion_mirror
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job PASSED.

@udaysk23 udaysk23 dismissed sagihirshfeld’s stale review November 14, 2023 04:52

Made changes based on comments

keesturam
keesturam reviewed Nov 15, 2023
View reviewed changes
ocs_ci/ocs/resources/mcg.py Outdated Show resolved Hide resolved
ocs_ci/ocs/resources/mcg.py Outdated Show resolved Hide resolved
@udaysk23 udaysk23 force-pushed the test_multiregion_mirror branch 2 times, most recently from 08fa710 to 15c2f0f Compare November 28, 2023 15:45
ocs-ci
ocs-ci reviewed Nov 28, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown PR validation on existing cluster

Cluster Name: ukurundw-ibm-3
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job state: ABORTED.

@udaysk23 udaysk23 force-pushed the test_multiregion_mirror branch from 15c2f0f to 43b95af Compare November 28, 2023 15:53
@udaysk23 udaysk23 requested a review from keesturam November 29, 2023 07:33
ocs-ci
ocs-ci reviewed Nov 29, 2023
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name: ukurundw-pr
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/mcg/test_multi_region.py::TestMultiRegion::test_multiregion_mirror
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job PASSED.

sagihirshfeld
sagihirshfeld reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@sagihirshfeld sagihirshfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final minor suggestions - if you choose to incorporate the changes, a PR validation rerun won't be necessary as far as I'm concerned, because they don't affect the logic of the method.

ocs_ci/ocs/resources/mcg.py Outdated Show resolved Hide resolved
ocs_ci/ocs/resources/mcg.py Outdated Show resolved Hide resolved
@udaysk23
Fixes mirroring timeout issue
f9dc94b 
Fixes mirroring timeout issue Signed-off-by: Uday Kurundwade <[email protected]>
@udaysk23 udaysk23 force-pushed the test_multiregion_mirror branch from 43b95af to f9dc94b Compare November 30, 2023 07:22
sagihirshfeld
sagihirshfeld approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@sagihirshfeld sagihirshfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Nov 30, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: keesturam, sagihirshfeld, tiffanyn108, udaysk23

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@keesturam keesturam merged commit 3251d5f into red-hat-storage:master Dec 12, 2023
5 of 6 checks passed
paraggit pushed a commit to paraggit/ocs-ci that referenced this pull request Dec 20, 2023
@udaysk23 @paraggit
Fixes mirroring timeout issue (red-hat-storage#8658)
911620c 
Fixes mirroring timeout issue Signed-off-by: Uday Kurundwade <[email protected]>

Co-authored-by: Uday Kurundwade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@tiffanyn108 tiffanyn108 tiffanyn108 approved these changes

@sagihirshfeld sagihirshfeld sagihirshfeld approved these changes

@keesturam keesturam keesturam approved these changes

@mashetty330 mashetty330 Awaiting requested review from mashetty330

Assignees

@keesturam keesturam

@sagihirshfeld sagihirshfeld

@tiffanyn108 tiffanyn108

Labels
lgtm MCG Multi Cloud Gateway / NooBaa related issues size/M PR that changes 30-99 lines Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_multiregion_mirror sometimes fails to complete mirroring in time
5 participants
@udaysk23 @keesturam @sagihirshfeld @tiffanyn108 @ocs-ci