-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_dashboard_validation_ui-adjust-locator-4.14 #8607
test_dashboard_validation_ui-adjust-locator-4.14 #8607
Conversation
Signed-off-by: Daniel Osypenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: dosypenk-110e
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml
PR Test Suite: tier1
PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master
Job UNSTABLE (some or all tests failed).
Signed-off-by: Daniel Osypenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: dosypenk-110e
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml
PR Test Suite: tier1
PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master
Job UNSTABLE (some or all tests failed).
bad driver installation. rare system issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: dosypenk-110e
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml
PR Test Suite: tier1
PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master
Job UNSTABLE (some or all tests failed).
chrome crashed on Jenkins slave. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: dosypenk-110e
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml
PR Test Suite: tier1
PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master
Job UNSTABLE (some or all tests failed).
removed chrome browser on slave, rerunning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: dosypenk-110e
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml
PR Test Suite: tier1
PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master
Job UNSTABLE (some or all tests failed).
Signed-off-by: Daniel Osypenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: dosypenk-210e
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml
PR Test Suite: tier1
PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master
all previous failures related to unwanted session with browser |
@@ -473,7 +479,11 @@ def odf_overview_ui( | |||
|
|||
if not all(res_dict.values()): | |||
failed_checks = [check for check, res in res_dict.items() if not res] | |||
pytest.fail("Following checks failed: {}".format(failed_checks)) | |||
pytest.fail( | |||
"Following checks failed. 1 - Pass, 0 - Fail. \n{}".format( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct with pytest.fail and 0 failed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a legend for the log message.
In case of failure it will look like this. I did not have patience to replace "1" and "0" and run test validation job with readable True and False
so added a legend before printing this table
+------------+---------+
| check name | result |
+============+=========+
| check_a | 1 |
+------------+---------+
| check_b | 1 |
+------------+---------+
| check_c | 0 |
+------------+---------+
| check_d | 1 |
+------------+---------+
| check_e | 1 |
+------------+---------+
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DanielOsypenko, ebenahar, ebondare, OdedViner The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adjust locator to changes in html
FIXES #8606