Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_dashboard_validation_ui-adjust-locator-4.14 #8607

Conversation

DanielOsypenko
Copy link
Contributor

adjust locator to changes in html
FIXES #8606

@DanielOsypenko DanielOsypenko added ui_automation Squad/Black Covers UI specific test cases such as ODF Dashboard etc. labels Oct 1, 2023
@DanielOsypenko DanielOsypenko requested a review from a team as a code owner October 1, 2023 09:17
@DanielOsypenko DanielOsypenko self-assigned this Oct 1, 2023
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: dosypenk-110e
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml
PR Test Suite: tier1
PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

Signed-off-by: Daniel Osypenko <[email protected]>
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines and removed size/XS labels Oct 1, 2023
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: dosypenk-110e
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml
PR Test Suite: tier1
PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

@DanielOsypenko
Copy link
Contributor Author

PR validation on existing cluster

Cluster Name: dosypenk-110e Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml PR Test Suite: tier1 PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui Additional Test Params: OCP VERSION: 4.14 OCS VERSION: 4.14 tested against branch: master

Job UNSTABLE (some or all tests failed).

bad driver installation. rare system issue

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: dosypenk-110e
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml
PR Test Suite: tier1
PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

@DanielOsypenko
Copy link
Contributor Author

DanielOsypenko commented Oct 1, 2023

PR validation on existing cluster

Cluster Name: dosypenk-110e Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml PR Test Suite: tier1 PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui Additional Test Params: OCP VERSION: 4.14 OCS VERSION: 4.14 tested against branch: master

Job UNSTABLE (some or all tests failed).

chrome crashed on Jenkins slave.
removed driver, rerunning

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: dosypenk-110e
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml
PR Test Suite: tier1
PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

@DanielOsypenko
Copy link
Contributor Author

PR validation on existing cluster

Cluster Name: dosypenk-110e Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml PR Test Suite: tier1 PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui Additional Test Params: OCP VERSION: 4.14 OCS VERSION: 4.14 tested against branch: master

Job UNSTABLE (some or all tests failed).

removed chrome browser on slave, rerunning

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: dosypenk-110e
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml
PR Test Suite: tier1
PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job UNSTABLE (some or all tests failed).

Signed-off-by: Daniel Osypenko <[email protected]>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: dosypenk-210e
Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml
PR Test Suite: tier1
PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui
Additional Test Params:
OCP VERSION: 4.14
OCS VERSION: 4.14
tested against branch: master

Job PASSED.

@DanielOsypenko
Copy link
Contributor Author

PR validation on existing cluster

Cluster Name: dosypenk-210e Cluster Configuration: conf/deployment/vsphere/upi_1az_rhcos_vsan_3m_3w.yaml conf/ocsci/external_rhcs_cluster.yaml PR Test Suite: tier1 PR Test Path: tests/ui/test_validation_ui.py::TestUserInterfaceValidation::test_dashboard_validation_ui Additional Test Params: OCP VERSION: 4.14 OCS VERSION: 4.14 tested against branch: master

Job PASSED.

all previous failures related to unwanted session with browser headless: False came from debugging. - reverted, test now passes on External mode cluster

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2023
@DanielOsypenko DanielOsypenko requested a review from a team October 2, 2023 15:49
@DanielOsypenko DanielOsypenko added the Verified Mark when PR was verified and log provided label Oct 3, 2023
@@ -473,7 +479,11 @@ def odf_overview_ui(

if not all(res_dict.values()):
failed_checks = [check for check, res in res_dict.items() if not res]
pytest.fail("Following checks failed: {}".format(failed_checks))
pytest.fail(
"Following checks failed. 1 - Pass, 0 - Fail. \n{}".format(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct with pytest.fail and 0 failed?

Copy link
Contributor Author

@DanielOsypenko DanielOsypenko Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a legend for the log message.

In case of failure it will look like this. I did not have patience to replace "1" and "0" and run test validation job with readable True and False
so added a legend before printing this table

+------------+---------+
| check name | result  |
+============+=========+
| check_a    | 1       |
+------------+---------+
| check_b    | 1       |
+------------+---------+
| check_c    | 0       |
+------------+---------+
| check_d    | 1       |
+------------+---------+
| check_e    | 1       |
+------------+---------+

@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DanielOsypenko, ebenahar, ebondare, OdedViner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebenahar ebenahar merged commit 46d769e into red-hat-storage:master Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/M PR that changes 30-99 lines Squad/Black Covers UI specific test cases such as ODF Dashboard etc. ui_automation Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix storageclass-link Xpath for dashboard_validation test. External mode
6 participants