Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROSA HCP] test_nodereplacement_proactive - fixed #11065

Merged
merged 1 commit into from
Dec 18, 2024
Merged

[ROSA HCP] test_nodereplacement_proactive - fixed #11065

merged 1 commit into from
Dec 18, 2024

Conversation

DanielOsypenko
Copy link
Contributor

stop fails on waiting new node in machinepool, add TimeoutSampler

Verification executed locally: https://url.corp.redhat.com/df6f756

@DanielOsypenko DanielOsypenko requested a review from a team December 18, 2024 15:03
@DanielOsypenko DanielOsypenko self-assigned this Dec 18, 2024
@DanielOsypenko DanielOsypenko requested a review from a team as a code owner December 18, 2024 15:03
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Dec 18, 2024
@openshift-ci openshift-ci bot added the lgtm label Dec 18, 2024
@DanielOsypenko DanielOsypenko added the Verified Mark when PR was verified and log provided label Dec 18, 2024
@DanielOsypenko
Copy link
Contributor Author

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link
Collaborator

@DanielOsypenko: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@DanielOsypenko DanielOsypenko changed the title test_nodereplacement_proactive - fixed [ROSA HCP] test_nodereplacement_proactive - fixed Dec 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AviadP, dahorak, DanielOsypenko

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dahorak dahorak merged commit 8a8a611 into red-hat-storage:master Dec 18, 2024
6 of 7 checks passed
@openshift-cherrypick-robot
Copy link
Collaborator

@DanielOsypenko: new pull request created: #11066

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AviadP AviadP AviadP approved these changes

@dahorak dahorak dahorak approved these changes

Assignees

@dahorak dahorak

@AviadP AviadP

@DanielOsypenko DanielOsypenko

Labels
lgtm size/S PR that changes 10-29 lines Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielOsypenko @openshift-cherrypick-robot @dahorak @AviadP