Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROSA HCP] exclude external dns if unavailable in CLI #11057

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −1
Open

[ROSA HCP] exclude external dns if unavailable in CLI #11057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a055ff
excluded external ip if unavailable in CLI
DanielOsypenko Dec 17, 2024
3ec4337
remove internal dns from addresses
DanielOsypenko Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ocs_ci/ocs/ui/odf_topology.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ def get_node_details_cli(node_name) -> dict:
_address_dict = {item["type"]: item["address"] for item in _addresses}
node_details["addresses"] = (
f"External IP: {_address_dict.get('ExternalIP')}; "
if _address_dict.get("ExternalIP")
else ""
f"Hostname: {_address_dict.get('Hostname')}; "
f"Internal IP: {_address_dict.get('InternalIP')}"
)
Expand Down
7 changes: 6 additions & 1 deletion ocs_ci/ocs/ui/page_objects/odf_topology_tab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1023,7 +1023,12 @@ def read_details(self) -> dict:
for detail_name, loc in filtered_dict.items():
if detail_name == "details_sidebar_node_addresses":
node_addresses = self.get_elements(loc)
addresses_txt = [el.text for el in node_addresses]
# exclude Internal DNS from addresses, it is applicable only for specific platforms
addresses_txt = [
el.text
for el in node_addresses
if not el.text.startswith("Internal DNS")
]
addresses_txt = "; ".join(addresses_txt)
details_dict[
detail_name.split("details_sidebar_node_", 1)[-1].strip()
Expand Down
Loading