Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new test file for mcg cli commands validation with bucket list command verification #11046

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ypersky1980
Copy link
Contributor

@ypersky1980 ypersky1980 commented Dec 13, 2024

This PR contains adding a new file for mcg cli commands validation.
Currently there is one test for validation of mcg cli bucket list command.
The test implements the following flow:
1) runs this command to count the number of existing buckets
2) creates number of buckets
3) runs bucket list command again
4) verifies that the number of current buckets equals the number of previously existing and the added ones

@ypersky1980 ypersky1980 requested a review from a team as a code owner December 13, 2024 16:26
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Dec 13, 2024
Signed-off-by: Yulia Persky <[email protected]>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/object/mcg/test_mcg_cli.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

@ypersky1980 ypersky1980 added the Verified Mark when PR was verified and log provided label Dec 14, 2024
udaysk23
udaysk23 previously approved these changes Dec 16, 2024
@openshift-ci openshift-ci bot added the lgtm label Dec 16, 2024
@udaysk23 udaysk23 added the MCG Multi Cloud Gateway / NooBaa related issues label Dec 16, 2024
)
logger.info(f"{existing_buckets_num} bucket(s) exist")

count = 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ypersky1980 why do we hardcode 3 buckets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keesturam , Currently 3 is the value of the "count" parameter.
Would you like me to make "count" an argument? Would you like this test to run once with count=3 and another time with count=30?

ocs-ci

This comment was marked as outdated.

ocs-ci

This comment was marked as outdated.

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ypersky-18four
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/object/mcg/test_mcg_cli.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

@openshift-ci openshift-ci bot added the lgtm label Dec 18, 2024
Copy link

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: udaysk23, ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm MCG Multi Cloud Gateway / NooBaa related issues size/M PR that changes 30-99 lines Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants