-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a new test file for mcg cli commands validation with bucket list command verification #11046
base: master
Are you sure you want to change the base?
Conversation
… verification Signed-off-by: Yulia Persky <[email protected]>
Signed-off-by: Yulia Persky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/object/mcg/test_mcg_cli.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master
) | ||
logger.info(f"{existing_buckets_num} bucket(s) exist") | ||
|
||
count = 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ypersky1980 why do we hardcode 3 buckets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keesturam , Currently 3 is the value of the "count" parameter.
Would you like me to make "count" an argument? Would you like this test to run once with count=3 and another time with count=30?
Signed-off-by: Yulia Persky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: ypersky-18four
Cluster Configuration:
PR Test Suite: tier2
PR Test Path: tests/functional/object/mcg/test_mcg_cli.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: udaysk23, ypersky1980 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains adding a new file for mcg cli commands validation.
Currently there is one test for validation of mcg cli bucket list command.
The test implements the following flow:
1) runs this command to count the number of existing buckets
2) creates number of buckets
3) runs bucket list command again
4) verifies that the number of current buckets equals the number of previously existing and the added ones