-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: IBM Cloud ROKS RDR changes #10977
base: release-4.16
Are you sure you want to change the base?
WIP: IBM Cloud ROKS RDR changes #10977
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: petr-balogh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
77b7b59
to
aa4ce23
Compare
0f28a36
to
f16a2a4
Compare
@@ -11,6 +11,6 @@ DEPLOYMENT: | |||
ENV_DATA: | |||
# TODO: replace with 4.16 once template is available | |||
vm_template: "rhcos-416.94.202403071059-0-vmware.x86_64" | |||
acm_hub_channel: release-2.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This we need to probably change somewhere else or get ACK with @keesturam or @sidhant-agrawal that we can do change this version globally for 4.16 to ACM 2.12.
@functools.wraps(func) | ||
def wrapper(*args, **kwargs): | ||
for cluster_index in range(self.nclusters): | ||
self.switch_ctx(cluster_index) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to use context manager which is switching back to original context or store original context and once function will finish, switch back to original context.
0cb3d03
to
e062a87
Compare
85d35c2
to
a806968
Compare
In RDR deployment, the zone key in ENV_DATA is used for different purpose, so changing it to worker_availability_zone here. Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
run_for_all_clusters allow to run existing function on all cluster configs. It's usefull when you need to globally update some config value for all clusters. Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
And not disable NAT-T for ROKS cluster Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
Signed-off-by: Petr Balogh <[email protected]>
a806968
to
ffc279f
Compare
Signed-off-by: Petr Balogh <[email protected]>
ffc279f
to
6be7dd4
Compare
No description provided.