IPI disk removal when cluster is destroyed #10916
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyRozen
force-pushed
the
ipi_remove_disk
branch
from
3bb1e26 to
dff467b
Compare
shyRozen
force-pushed
the
ipi_remove_disk
branch
2 times, most recently
from
2c86b12 to
33b279c
Compare
ocs-ci
reviewed
Dec 8, 2024
vavuthu
previously approved these changes
Dec 9, 2024
shyRozen
force-pushed
the
ipi_remove_disk
branch
from
33b279c to
0dac516
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shyRozen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shyRozen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shyRozen
changed the title
ocs-ci
reviewed
Dec 12, 2024
Signed-off-by: Shay Rozen <[email protected]>
shyRozen
force-pushed
the
ipi_remove_disk
branch
from
0dac516 to
1f51238
Compare
|
New changes are detected. LGTM label has been removed. |
ocs-ci
reviewed
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems when we do destroy IPI cluster we use openshift-install destroy cluster which leaves all vmdk files in the datastore.
This PR should resolve the problem.