-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensuring File Completeness Post-fsync with Shared CephFS Volume #10885
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Oded Viner <[email protected]>
Signed-off-by: Oded Viner <[email protected]>
Signed-off-by: Oded Viner <[email protected]>
pod_name = "cephfs-rwx-pod" | ||
project_obj = helpers.create_project(project_name=project_name) | ||
worker_node_names = get_worker_nodes() | ||
teardown_project_factory(project_obj) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is teardown called here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the method in our framework. After creating the namespace, we will delete all objects within the namespace and the namespace itself.
project_obj = helpers.create_project(project_name=project_name) | ||
worker_node_names = get_worker_nodes() | ||
teardown_project_factory(project_obj) | ||
logger.info( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be printed after helpers.create_pvc succeds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed the log:)
teardown_project_factory(project_obj) | ||
logger.info( | ||
f"Created new pvc sc_name={constants.CEPHFILESYSTEM_SC} namespace={project_name}, " | ||
f"size=6Gi, access_mode={constants.ACCESS_MODE_RWO}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This log message mentions the access mode constants.ACCESS_MODE_RWO, but the PVC is created with constants.ACCESS_MODE_RWX. Was this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
pod_obj_client = helpers.create_pod( | ||
pvc_name=pvc_obj.name, | ||
namespace=project_obj.namespace, | ||
interface_type=constants.CEPHBLOCKPOOL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PVC is created with constants.CEPHFILESYSTEM_SC, which refers to CephFS, but the pods are being created with constants.CEPHBLOCKPOOL as the interface_type, does it works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
$ oc get pvc -n cephfs-rwx-ns
NAME STATUS VOLUME CAPACITY ACCESS MODES STORAGECLASS VOLUMEATTRIBUTESCLASS AGE
pvc-test-6c5c86da89904beeb412eecd9502073 Bound pvc-7a67273a-7977-470a-b60b-36604ecb48cb 6Gi RWX ocs-storagecluster-cephfs <unset> 94s
$ oc get pods client -o yaml | grep -i pvc-test-6c5c86da89904beeb412eecd9502073 -A 1 -B 3
volumes:
- name: mypvc
persistentVolumeClaim:
claimName: pvc-test-6c5c86da89904beeb412eecd9502073
$ oc get pods server -o yaml | grep -i pvc-test-6c5c86da89904beeb412eecd9502073 -A 1 -B 3
volumes:
- name: mypvc
persistentVolumeClaim:
claimName: pvc-test-6c5c86da89904beeb412eecd9502073
Signed-off-by: Oded Viner <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: OdedViner, paraggit The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://bugzilla.redhat.com/show_bug.cgi?id=2212310