Skip to content

Commit

Permalink
Updated local storage option operator image details
Browse files Browse the repository at this point in the history
Signed-off-by: Amrita Mahapatra <[email protected]>
  • Loading branch information
amr1ta committed Jun 4, 2024
1 parent 4cb8748 commit f3ce986
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 13 deletions.
30 changes: 18 additions & 12 deletions ocs_ci/ocs/resources/storage_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,7 @@ def create_storage_client(
log.info("Creating storageclient CR")
self.ocp_obj.exec_oc_cmd(f"apply -f {storage_client_data_yaml.name}")

def fetch_storage_client_status(
self, namespace=config.ENV_DATA["cluster_namespace"], storageclient_name=None
):
def fetch_storage_client_status(self, namespace=None, storageclient_name=None):
"""
Fetch storageclient status
Expand All @@ -180,8 +178,11 @@ def fetch_storage_client_status(
storageclient_status(str): storageclient phase
"""
if not namespace:
namespace = config.ENV_DATA["cluster_namespace"]

cmd = (
f"oc get storageclient {storageclient_name} -n {namespace} "
f"get storageclient {storageclient_name} -n {namespace} "
"-o=jsonpath='{.items[*].status.phase}'"
)
storageclient_status = self.ocp_obj.exec_oc_cmd(
Expand Down Expand Up @@ -300,7 +301,7 @@ def verify_storagerequest_exists(
storagerequest_exists (bool): returns true if the storagerequest exists
"""
cmd = f"oc get storagerequests -n {namespace} " "-o=jsonpath='{.items[*]}'"
cmd = f"get storagerequests -n {namespace} " "-o=jsonpath='{.items[*]}'"
storage_requests = self.ocp_obj.exec_oc_cmd(command=cmd, out_yaml_format=True)

log.info(f"The list of storagerequests: {storage_requests}")
Expand All @@ -315,7 +316,7 @@ def verify_storagerequest_exists(
def verify_storageclient_status(
self,
storageclient_name,
namespace=config.ENV_DATA["cluster_namespace"],
namespace=None,
expected_storageclient_status="Connected",
):
"""
Expand All @@ -330,10 +331,12 @@ def verify_storageclient_status(
storagerequest_phase == expected_storageclient_status
"""
if not namespace:
namespace = config.ENV_DATA["cluster_namespace"]

# Check storage client is in 'Connected' status
storage_client_status = self.fetch_storage_client_status(
storageclient_name, namespace=namespace
storageclient_name=storageclient_name, namespace=namespace
)
assert (
storage_client_status == expected_storageclient_status
Expand Down Expand Up @@ -430,7 +433,7 @@ def create_native_storage_client(
onboarding_token=onboarding_token,
)

if self.ocs_version < 4.16:
if self.ocs_version < version.VERSION_4_16:
self.create_storageclaim(
storageclaim_name="ocs-storagecluster-ceph-rbd",
type="blockpool",
Expand All @@ -451,7 +454,7 @@ def verify_native_storageclient(self):
storageclaims, associated storageclasses and storagerequests are created successfully.
"""
if self.ocs_version >= 4.16:
if self.ocs_version >= version.VERSION_4_16:
namespace = config.ENV_DATA["cluster_namespace"]
else:
namespace = constants.OPENSHIFT_STORAGE_CLIENT_NAMESPACE
Expand All @@ -460,12 +463,15 @@ def verify_native_storageclient(self):
kind=constants.STORAGECLIENT,
namespace=namespace,
)
storageclient = storageclient_obj.get()["items"][0]
storageclient_name = storageclient["metadata"]["name"]

# Verify storageclient is in Connected status
assert self.verify_storageclient_status(namespace=namespace)
assert self.verify_storageclient_status(
storageclient_name=storageclient_name, namespace=namespace
)

# Validate storageclaims are Ready and associated storageclasses are created
storageclient = storageclient_obj.get()["items"][0]
storageclient_name = storageclient["metadata"]["name"]
verify_storageclient_storageclass_claims(storageclient_name)

# Validate storagerequests are created successfully
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ spec:
icon:
base64data: ""
mediatype: ""
image: quay.io/openshift-qe-optional-operators/ocp4-index:latest
image: quay.io/openshift-qe-optional-operators/aosqe-index:latest
publisher: Red Hat
sourceType: grpc

0 comments on commit f3ce986

Please sign in to comment.