Skip to content

Commit

Permalink
fix test_failure_propagator (#8688)
Browse files Browse the repository at this point in the history
* fix test_failure_propagator

- set default skipped_on_ceph_health_threshold to 0
- update rounding of skipped_on_ceph_health_ratio to 3 digits
- update README

Signed-off-by: Daniel Horak <[email protected]>
  • Loading branch information
dahorak authored Oct 17, 2023
1 parent 97f7ad2 commit d74b2df
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions conf/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ run it belongs here.
* `skipped_on_ceph_health_ratio` - The ratio of tests skipped due to Ceph unhealthy against the
number of tests being collected for the test execution
* `skipped_on_ceph_health_threshold` - The allowed threshold for the ratio of tests skipped due to Ceph unhealthy against the
number of tests being collected for the test execution. The default value is set to 0.1 (10%).
For acceptance suite, the value would be set to 0
number of tests being collected for the test execution. The default value is set to 0.
For acceptance suite, the value would be always overwritten to 0.

#### DEPLOYMENT

Expand Down
2 changes: 1 addition & 1 deletion ocs_ci/framework/conf/default_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ RUN:
skipped_tests_ceph_health: 0
number_of_tests: None
skipped_on_ceph_health_ratio: 0
skipped_on_ceph_health_threshold: 0.1
skipped_on_ceph_health_threshold: 0


# In this section we are storing all deployment related configuration but not
Expand Down
2 changes: 1 addition & 1 deletion tests/test_failure_propagator.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def test_report_skip_triggering_test(self, request):
config.RUN.get("skipped_tests_ceph_health")
/ number_of_eligible_tests
),
1,
3,
)
log.info(
f"skipped_on_ceph_health_ratio: {config.RUN.get('skipped_on_ceph_health_ratio')}"
Expand Down

0 comments on commit d74b2df

Please sign in to comment.