Merge pull request #10694 from vavuthu/remove_duplicate_rotational_in…

…_localvolume_set remove Rotational duplicate in LocalVolumeSet
red-hat-storage · Oct 17, 2024 · 596f384 · 596f384
2 parents 5a495ec + c6efea4
commit 596f384
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/ocs_ci/deployment/helpers/lso_helpers.py b/ocs_ci/deployment/helpers/lso_helpers.py
@@ -145,8 +145,10 @@ def setup_local_storage(storageclass):
         # Since we don't have datastore with SSD on our current VMware machines, localvolumeset doesn't detect
         # NonRotational disk. As a workaround we are setting Rotational to device MechanicalProperties to detect
         # HDD disk
-        if platform == constants.VSPHERE_PLATFORM or config.ENV_DATA.get(
-            "local_storage_allow_rotational_disks"
+        if (
+            platform == constants.VSPHERE_PLATFORM
+            or config.ENV_DATA.get("local_storage_allow_rotational_disks")
+            or config.ENV_DATA.get("odf_provider_mode_deployment")
         ):
             logger.info(
                 "Adding Rotational for deviceMechanicalProperties spec"

diff --git a/ocs_ci/templates/ocs-deployment/local-volume-set.yaml b/ocs_ci/templates/ocs-deployment/local-volume-set.yaml
@@ -6,7 +6,6 @@ metadata:
 spec:
     deviceInclusionSpec:
       deviceMechanicalProperties:
-      - Rotational
       - NonRotational
       deviceTypes:
       - disk