Utilize PHPStan Type interface in TypeNormalizer #6478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Nov 23, 2024
| ++$arrayNesting; | ||
| $this->normalizeArrayOfUnionToUnionArray($type->getItemType(), $arrayNesting); |
There was a problem hiding this comment.
the root cause is that we call getItemType which is not defined in Type, therefore will crash depending on the used type
samsonasik
reviewed
Nov 23, 2024
| } elseif ($type->getItemType() instanceof UnionType) { | ||
| $this->collectNestedArrayTypeFromUnionType($type->getItemType(), $arrayNesting); | ||
| $this->normalizeArrayOfUnionToUnionArray($itemType, $arrayNesting); | ||
| } elseif ($itemType instanceof UnionType) { |
There was a problem hiding this comment.
this can be IntersectionType, see PR patch that happen on downgrade:
due to downgrade error:
until we have more fixture tests, I think we can keep using strict ArrayType and ConstantArrayType to avoid regression.
There was a problem hiding this comment.
ok, lets do it less aggressive: #6479
|
let's close in favor of #6479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes the root cause of rectorphp/rector#8907