Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Php84] Add ExplicitNullableParamTypeRector #5724

Merged
merged 11 commits into from
Mar 15, 2024
Merged

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik
Copy link
Member Author

implemented 🎉 /cc @mfn
@TomasVotruba I think it is ready 👍

@TomasVotruba
Copy link
Member

Looks good, thank you 🥳

@TomasVotruba TomasVotruba merged commit ff32c0c into main Mar 15, 2024
41 checks passed
@TomasVotruba TomasVotruba deleted the php84-explicit-null branch March 15, 2024 10:43

public function provideMinPhpVersion(): int
{
return PhpVersionFeature::DEPRECATE_IMPLICIT_NULLABLE_PARAM_TYPE;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be changed to PHP 7.1, as this is the minimum version that support the nullable types. Projects need to make this change in order to be fully compatible with PHP 7.4: #5848

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would we optional coding style preference. Since PHP 8.4 it's part of required upgrade path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a rule to convert implicitly nullable types to explict ones?
3 participants