Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Downgradephp80] Better add new line handling with insert \n prefix for same line attribute DowngradeAttributeToAnnotationRector skipped class #252

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[Downgradephp80] Better add new line handling with insert \n prefix for same line attribute DowngradeAttributeToAnnotationRector skipped class #252

merged 2 commits into from
Nov 25, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Nov 25, 2024 •
edited
Loading

continue of

It seems add new line no token next is better for it, so it keep attribute, but new lined.

@samsonasik samsonasik closed this Nov 25, 2024
@samsonasik samsonasik reopened this Nov 25, 2024
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 207269f into main Nov 25, 2024
6 checks passed
@samsonasik samsonasik deleted the better-add-new-line branch November 25, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @actions-user