Remove no longer needed FUNC_ARGS_TRAILING_COMMA attribute usage mark…

…er on downgrade rules (#250)
rectorphp · Nov 23, 2024 · ecd33d6 · ecd33d6
1 parent 08b98b3
commit ecd33d6
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 3 deletions.
diff --git a/rules/DowngradePhp73/Rector/FuncCall/DowngradeTrailingCommasInFunctionCallsRector.php b/rules/DowngradePhp73/Rector/FuncCall/DowngradeTrailingCommasInFunctionCallsRector.php
@@ -91,7 +91,6 @@ public function refactor(Node $node): ?Node
         }
 
         // remove comma
-        $lastArg->setAttribute(AttributeKey::FUNC_ARGS_TRAILING_COMMA, false);
         $node->setAttribute(AttributeKey::ORIGINAL_NODE, null);
 
         return $node;

diff --git a/rules/DowngradePhp73/Rector/Unset_/DowngradeTrailingCommasInUnsetRector.php b/rules/DowngradePhp73/Rector/Unset_/DowngradeTrailingCommasInUnsetRector.php
@@ -68,7 +68,6 @@ public function refactor(Node $node): ?Node
             }
 
             // remove comma
-            $last->setAttribute(AttributeKey::FUNC_ARGS_TRAILING_COMMA, false);
             $node->setAttribute(AttributeKey::ORIGINAL_NODE, null);
 
             return $node;

diff --git a/rules/DowngradePhp80/Rector/ClassMethod/DowngradeTrailingCommasInParamUseRector.php b/rules/DowngradePhp80/Rector/ClassMethod/DowngradeTrailingCommasInParamUseRector.php
@@ -123,7 +123,6 @@ private function cleanTrailingComma(Closure|ClassMethod|Function_ $node, array $
         }
 
         $node->setAttribute(AttributeKey::ORIGINAL_NODE, null);
-        $last->setAttribute(AttributeKey::FUNC_ARGS_TRAILING_COMMA, false);
 
         return $node;
     }
-Original file line number
+Diff line change
@@ Expand Up @@
             }
             $node->setAttribute(AttributeKey::ORIGINAL_NODE, null);
-            $last->setAttribute(AttributeKey::FUNC_ARGS_TRAILING_COMMA, false);
             return $node;
         }
@@ Expand Down @@