⚠️ Fixed processing of the selection range made totally outside of the container ⚠️ #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-danylchenko
force-pushed
the
fix-trimming-out-of-container
branch
from
cfbd296
to
dbdcf6e
Compare
oleksandr-danylchenko
changed the title
# Conflicts: # packages/text-annotator/src/utils/index.ts
# Conflicts: # packages/text-annotator/src/utils/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When the selection range was made entirely outside of the container - we should treat it as a collapsed one and discard it. However, this wasn't the case with the⚠️
trimRangeToContainermethod I introduced in #134. Instead, it would make the outside range cover the container