feat: Bridge module and upgrade sdk50 #179
Conversation
feat: bridge module
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| valIter := app.StakingKeeper.ValidatorQueueIterator(ctx, oneEnternityLater, 99999999999999) | ||
| valIter, err := app.StakingKeeper.ValidatorQueueIterator(ctx, oneEnternityLater, 99999999999999) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| unbondingTimesliceIterator := sk.UBDQueueIterator(ctx, oneEnternityLater) // make sure to iterate all queue | ||
| unbondingTimesliceIterator, err := sk.UBDQueueIterator(ctx, oneEnternityLater) // make sure to iterate all queue | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
|
@trinitys7 @catShaark do we need to write a migrate function for converting |
No we don't, I tested them on mainnet state upgrade |
| // Ethereum keys | ||
| meter.ConsumeGas(evmosante.Secp256k1VerifyCost, "ante verify: eth_secp256k1") | ||
| return nil | ||
| case *ethsecp256k1.PubKey: |
There was a problem hiding this comment.
For backward compability with acount that has ethermint key.
There was a problem hiding this comment.
The ethsecp256k1 Pubkey is the pubkey for ethermint one, while the osecp256k1 Pubkey is the pubkey for evmos os, as we move from ethermint to os, the ethermint key will still be store in local keyring.
There was a problem hiding this comment.
you are right, I can ask the evmos team if they can support the ethermint type so we dont have to support mulutiple types
|
PR should be block until fixing the ante handler issues. I stopped the review there giving that that change should have significant changes in multiple files. Once it is fixed I will continue the review. |
No description provided.