Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/asset): Add clawback and transfer auth priviledges #176
base: example-priv
Are you sure you want to change the base?
feat(x/asset): Add clawback and transfer auth priviledges #176
Changes from 4 commits
4583ff6
3be413f
25c7687
f5f6bb9
5897cec
f82ab74
f4c1ede
23b7c96
8ffadb0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 109 in x/asset/keeper/keeper_test.go
GitHub Actions / lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a comment in
x/asset/keeper/keeper.go
that we should not support more than 1RestrictionChecker
. However, the code seems to allow more than one anyway (bothx/asset/keeper/keeper.go
andx/asset/keeper/restriction.go
have the conditional checklen(k.RestrictionChecker) == 0
instead of something likelen(k.RestrictionChecker) != 1
for instance.This line
checker := k.RestrictionChecker[0]
will ignore anyRestrictionChecker
after the first one registered. If multiple exist, how can we be sure the first is the correct one to use? It seems the code should either enforce only oneRestrictionChecker
, or this code block should iterate allRestrictionCheckers
in this list.